HomePhabricator

LastCommonAncestor: use skiplist when available

Description

LastCommonAncestor: use skiplist when available

Summary:
We can take advantage of the fact that skip lists use identical heights
on both chains. This function was added back in 2014 (341735eb8f) and
for some reason didn't use the skip lists introduced a few weeks prior
(c9a0918330f31dcb1d5e86b56af63c3f521d3cf2).

Test Plan: ninja check

Reviewers: jasonbcox, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5067

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Jan 26 2020, 04:55
markblundebergPushed on Jan 28 2020, 12:01
Reviewer
Restricted Project
Differential Revision
D5067: LastCommonAncestor: use skiplist when available
Parents
rABC2d2e579a544f: AreOnTheSameFork: don't actually need to find common ancestor
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC0e59f54f82e7: LastCommonAncestor: use skiplist when available (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).Jan 28 2020, 12:00