Page MenuHomePhabricator
Differential D5067

LastCommonAncestor: use skiplist when available
ClosedPublic
Actions

Authored by markblundeberg on Jan 26 2020, 05:38.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0e59f54f82e7: LastCommonAncestor: use skiplist when available
rABC0e59f54f82e7: LastCommonAncestor: use skiplist when available
Summary

We can take advantage of the fact that skip lists use identical heights
on both chains. This function was added back in 2014 (341735eb8f) and
for some reason didn't use the skip lists introduced a few weeks prior
(c9a0918330f31dcb1d5e86b56af63c3f521d3cf2).

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jan 26 2020, 05:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2020, 05:38
teamcity added a comment.Jan 26 2020, 05:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 26 2020, 05:42

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9141: Diff 15791.Jan 26 2020, 05:42
markblundeberg added a reviewer: deadalnix.Jan 26 2020, 08:18
deadalnix accepted this revision.Jan 26 2020, 23:01
This revision is now accepted and ready to land.Jan 26 2020, 23:01
Closed by commit rABC0e59f54f82e7: LastCommonAncestor: use skiplist when available (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 28 2020, 12:01
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC0e59f54f82e7: LastCommonAncestor: use skiplist when available.
markblundeberg added inline comments.Jan 28 2020, 12:02
src/chain.cpp
184

I just realized this else doesn't actually need to be here (the next two lines can be run immediately even if skip was used, since they satisfy the while condition. Anyway...

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING0e59f54f82e7: LastCommonAncestor: use skiplist when available.Apr 7 2020, 22:40

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 15837

View Options

src/chain.cpp

Loading...