HomePhabricator

Remove unused depends list from `getblocktemplate` transactions

Authored by schancel on Apr 7 2019, 04:12.

Description

Remove unused depends list from getblocktemplate transactions

Summary:
Prior to CTOR, each transaction provided with getblocktemplate included a numerical list
of prior transcations (by index) that the given transaction depended on. (See: BIP022)

However, once CTOR was activated, this list became meaningless as there is no longer a
topological ordering contraint. Worse, since dependent transactions can appear later
in a block, this data does not indicate reliably to clients if there are dependencies.

Finally, the specification allows this value to be omitted. (See BIP022)

This commit, therefore, removes the extraneous and erroreous calculation.

Test Plan: make check && ./test/functional/test_runner.py

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D2782

Details

Committed
schancelApr 9 2019, 01:32
Pushed
schancelApr 9 2019, 01:32
Reviewer
Restricted Owners Package
Differential Revision
D2782: Remove unused depends list from `getblocktemplate` transactions
Parents
rABC0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
Branches
Unknown
Tags
Unknown