Page MenuHomePhabricator

Remove unused depends list from `getblocktemplate` transactions
ClosedPublic

Authored by schancel on Sun, Apr 7, 04:31.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC1201c8ad49e4: Remove unused depends list from `getblocktemplate` transactions
Summary

Prior to CTOR, each transaction provided with getblocktemplate included a numerical list
of prior transcations (by index) that the given transaction depended on. (See: BIP022)

However, once CTOR was activated, this list became meaningless as there is no longer a
topological ordering contraint. Worse, since dependent transactions can appear later
in a block, this data does not indicate reliably to clients if there are dependencies.

Finally, the specification allows this value to be omitted. (See BIP022)

This commit, therefore, removes the extraneous and erroreous calculation.

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Sun, Apr 7, 04:31
Owners added a reviewer: Restricted Owners Package.Sun, Apr 7, 04:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Apr 7, 04:31
jasonbcox requested changes to this revision.Sun, Apr 7, 04:46
jasonbcox added a subscriber: jasonbcox.

This should be mentioned in release notes.

This revision now requires changes to proceed.Sun, Apr 7, 04:46
schancel updated this revision to Diff 7988.Mon, Apr 8, 01:49

Update release notes

jasonbcox accepted this revision.Tue, Apr 9, 00:01
jasonbcox added inline comments.
doc/release-notes.md
9 ↗(On Diff #7988)

Since these release notes tend to be consumed by non-contributors, I think the diff link should be left out. A git blame can easily provide the diff if needed.

This revision is now accepted and ready to land.Tue, Apr 9, 00:01
This revision was automatically updated to reflect the committed changes.