HomePhabricator

Fix increment in rpc/mining.cpp when coinbase tx is skipped

Description

Fix increment in rpc/mining.cpp when coinbase tx is skipped

Summary:
D2782 introduces an off-by-one error when fetching fees and sigopscount from pblocktemplate.

https://build.bitcoinabc.org/viewLog.html?buildId=12706&tab=buildResultsDiv&buildTypeId=BitcoinABCMasterLinux

Test Plan:

make check
test_runner.py abc-magnetic-anomaly-mining

Reviewers: deadalnix, Fabien, schancel, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D2791

Details

Provenance
jasonbcoxAuthored on Apr 9 2019, 19:06
jasonbcoxPushed on Apr 10 2019, 17:46
Reviewer
Restricted Project
Differential Revision
D2791: Fix increment in rpc/mining.cpp when coinbase tx is skipped
Parents
rSTAGING45660ed52203: Migrate MakeUnique to c++14 std::make_unique
Branches
Unknown
Tags
Unknown