HomePhabricator

test: remove bare CTransaction `.rehash()` calls

Description

test: remove bare CTransaction .rehash() calls

Summary:
Since the previous commit, CTransaction object calls to the
methods .rehash() and .calc_sha256() are effectively no-ops
if the returned value is not used, so we can just remove them.

This is a partial backport of core#32421
https://github.com/bitcoin/bitcoin/pull/32421/commits/9b3dce24a3336a02563412b541a3fb2003e92506

Depends on D18712

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18713

Details

Provenance
Sebastian Falbesoner <sebastian.falbesoner@gmail.com>Authored on May 4 2025, 21:06
PiRKCommitted on Sep 30 2025, 09:48
PiRKPushed on Sep 30 2025, 09:48
Reviewer
Restricted Project
Differential Revision
D18713: test: remove bare CTransaction `.rehash()` calls
Parents
rABC496a019e7180: test: remove txid caching in CTransaction class
Branches
Unknown
Tags
Unknown