Paths

Table of Contentst

Differential D18713

test: remove bare CTransaction `.rehash()` calls
ClosedPublic
Actions

Authored by PiRK on Sep 29 2025, 15:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC13275833a495: test: remove bare CTransaction `.rehash()` calls

Summary

Since the previous commit, CTransaction object calls to the
methods .rehash() and .calc_sha256() are effectively no-ops
if the returned value is not used, so we can just remove them.

This is a partial backport of core#32421
https://github.com/bitcoin/bitcoin/pull/32421/commits/9b3dce24a3336a02563412b541a3fb2003e92506

Depends on D18712

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2025, 15:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2025, 15:36

PiRK requested review of this revision.Sep 29 2025, 15:36

teamcity edited the summary of this revision. (Show Details)Sep 29 2025, 15:36

PiRK added a child revision: D18714: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.Sep 29 2025, 15:38

Harbormaster completed remote builds in B34647: Diff 55945.Sep 29 2025, 15:50

PiRK planned changes to this revision.Sep 29 2025, 19:41

PiRK added inline comments.

test/functional/feature_block.py
525 ↗	(On Diff #55945)	this breaks feature_block and introduces an infinite loop. This is not a tx

unbreak feature_block.py

PiRK mentioned this in D18712: test: remove txid caching in CTransaction class.Sep 29 2025, 19:48

Harbormaster completed remote builds in B34654: Diff 55956.Sep 29 2025, 20:05

Fabien accepted this revision.Sep 30 2025, 07:23

This revision is now accepted and ready to land.Sep 30 2025, 07:23

Closed by commit rABC13275833a495: test: remove bare CTransaction `.rehash()` calls (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhySep 30 2025, 09:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC13275833a495: test: remove bare CTransaction `.rehash()` calls.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-mempool-coherence-on-activations.py

4 lines

abc-minimaldata.py

2 lines

abc-replay-protection.py

2 lines

abc-schnorr.py

2 lines

abc-schnorrmultisig.py

2 lines

abc-segwit-recovery.py

2 lines

abc-transaction-ordering.py

3 lines

abc_mining_stakingrewards.py

1 line

abc_p2p_avalanche_transaction_voting.py

4 lines

abc_p2p_compactblocks.py

4 lines

abc_p2p_fullblocktest.py

3 lines

chronik_block_info.py

2 lines

chronik_block_txs.py

2 lines

chronik_disable_token_index.py

1 line

chronik_lokad_id_group.py

5 lines

chronik_mempool_conflicts.py

3 lines

chronik_pause.py

1 line

chronik_plugins_setup.py

1 line

chronik_script_confirmed_txs.py

1 line

chronik_script_history.py

3 lines

chronik_script_unconfirmed_txs.py

2 lines

chronik_scripthash.py

1 line

chronik_shutdown.py

3 lines

chronik_spent_by.py

2 lines

chronik_token_alp.py

4 lines

chronik_token_broadcast_txs.py

7 lines

chronik_token_burn.py

3 lines

chronik_token_id_group.py

3 lines

chronik_token_parse_failure.py

2 lines

chronik_token_script_group.py

2 lines

chronik_token_slp_fungible.py

2 lines

chronik_token_slp_mint_vault.py

2 lines

chronik_token_slp_nft1.py

2 lines

chronik_ws_script.py

1 line

feature_63_bit_ints.py

2 lines

feature_bip68_sequence.py

2 lines

feature_block.py

18 lines

feature_coinstatsindex.py

1 line

feature_csv_activation.py

9 lines

feature_dersig.py

1 line

feature_tx_version.py

2 lines

46 lines

5 lines

3 lines

2 lines

1 line

rpc_gettransactionstatus.py

4 lines

setup_scripts/

chronik-client_broadcast_txs_and_validate_rawtx.py

4 lines

chronik-client_lokad_id.py

5 lines

chronik-client_mempool_conflicts.py

3 lines

chronik-client_token_slp_mint_vault.py

1 line

chronik-client_ws_txid.py

3 lines

test_framework/

blocktools.py

2 lines

chronik/

token_tx.py

1 line

messages.py

1 line

txtools.py

2 lines

Diff 55996

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-minimaldata.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc-segwit-recovery.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/abc_mining_stakingrewards.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_p2p_compactblocks.py

View Options

test/functional/abc_p2p_fullblocktest.py

View Options

test/functional/chronik_block_info.py

View Options

test/functional/chronik_block_txs.py

View Options

test/functional/chronik_disable_token_index.py

View Options

test/functional/chronik_lokad_id_group.py

View Options

test/functional/chronik_mempool_conflicts.py

View Options

test/functional/chronik_pause.py

View Options

test/functional/chronik_plugins_setup.py

View Options

test/functional/chronik_script_confirmed_txs.py

View Options

test/functional/chronik_script_history.py

View Options

test/functional/chronik_script_unconfirmed_txs.py

View Options

test/functional/chronik_scripthash.py

View Options

test/functional/chronik_shutdown.py

View Options

test/functional/chronik_spent_by.py

View Options

test/functional/chronik_token_alp.py

View Options

test/functional/chronik_token_broadcast_txs.py

View Options

test/functional/chronik_token_burn.py

View Options

test/functional/chronik_token_id_group.py

View Options

test/functional/chronik_token_parse_failure.py

View Options

test/functional/chronik_token_script_group.py

View Options

test/functional/chronik_token_slp_fungible.py

View Options

test/functional/chronik_token_slp_mint_vault.py

View Options

test/functional/chronik_token_slp_nft1.py

View Options

test/functional/chronik_ws_script.py

View Options

test/functional/feature_63_bit_ints.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_coinstatsindex.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_tx_version.py

View Options

test/functional/mempool_accept.py

View Options

test/functional/mining_basic.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/rpc_gettransactionstatus.py

View Options

test/functional/setup_scripts/chronik-client_broadcast_txs_and_validate_rawtx.py

View Options

test/functional/setup_scripts/chronik-client_lokad_id.py

View Options

test/functional/setup_scripts/chronik-client_mempool_conflicts.py

View Options

test/functional/setup_scripts/chronik-client_token_slp_mint_vault.py

View Options

test/functional/setup_scripts/chronik-client_ws_txid.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/chronik/token_tx.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/txtools.py

test: remove bare CTransaction `.rehash()` callsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 55996

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-minimaldata.py

test/functional/abc-replay-protection.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc-segwit-recovery.py

test/functional/abc-transaction-ordering.py

test/functional/abc_mining_stakingrewards.py

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/abc_p2p_compactblocks.py

test/functional/abc_p2p_fullblocktest.py

test/functional/chronik_block_info.py

test/functional/chronik_block_txs.py

test/functional/chronik_disable_token_index.py

test/functional/chronik_lokad_id_group.py

test/functional/chronik_mempool_conflicts.py

test/functional/chronik_pause.py

test/functional/chronik_plugins_setup.py

test/functional/chronik_script_confirmed_txs.py

test/functional/chronik_script_history.py

test/functional/chronik_script_unconfirmed_txs.py

test/functional/chronik_scripthash.py

test/functional/chronik_shutdown.py

test/functional/chronik_spent_by.py

test/functional/chronik_token_alp.py

test/functional/chronik_token_broadcast_txs.py

test/functional/chronik_token_burn.py

test/functional/chronik_token_id_group.py

test/functional/chronik_token_parse_failure.py

test/functional/chronik_token_script_group.py

test/functional/chronik_token_slp_fungible.py

test/functional/chronik_token_slp_mint_vault.py

test/functional/chronik_token_slp_nft1.py

test/functional/chronik_ws_script.py

test/functional/feature_63_bit_ints.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_coinstatsindex.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/feature_tx_version.py

test/functional/mempool_accept.py

test/functional/mining_basic.py

test/functional/p2p_compactblocks.py

test/functional/p2p_invalid_block.py

test/functional/p2p_invalid_tx.py

test/functional/rpc_gettransactionstatus.py

test/functional/setup_scripts/chronik-client_broadcast_txs_and_validate_rawtx.py

test/functional/setup_scripts/chronik-client_lokad_id.py

test/functional/setup_scripts/chronik-client_mempool_conflicts.py

test/functional/setup_scripts/chronik-client_token_slp_mint_vault.py

test/functional/setup_scripts/chronik-client_ws_txid.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/chronik/token_tx.py

test/functional/test_framework/messages.py

test/functional/test_framework/txtools.py

test: remove bare CTransaction `.rehash()` calls
ClosedPublic
Actions

Revision Contents
Changeset List