Paths

Table of Contentst

Differential D18714

.txid_hex for consistency
ClosedPublic
Actions

Authored by PiRK on Sep 29 2025, 15:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf5229b5e132f: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency

Summary

Note that we unfortunately can't use a scripted diff here, as the same
property and method name is also used for CBlockHeader/CBlock instances.

This is a partial backport of core#32421
https://github.com/bitcoin/bitcoin/pull/32421/commits/ce83924237127fe6d32b63c362b57789e4628954

Depends on D18713

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2025, 15:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2025, 15:38

PiRK requested review of this revision.Sep 29 2025, 15:38

teamcity edited the summary of this revision. (Show Details)Sep 29 2025, 15:38

PiRK added a child revision: D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.Sep 29 2025, 15:40

Harbormaster completed remote builds in B34648: Diff 55946.Sep 29 2025, 15:50

rebase

fix feature_block, which was previously hanging so i missed these missing instances

Harbormaster completed remote builds in B34655: Diff 55957.Sep 29 2025, 20:11

Harbormaster completed remote builds in B34658: Diff 55960.Sep 29 2025, 20:28

Fabien accepted this revision.Sep 30 2025, 07:24

This revision is now accepted and ready to land.Sep 30 2025, 07:24

Closed by commit rABCf5229b5e132f: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency (authored by PiRK). · Explain WhySep 30 2025, 09:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf5229b5e132f: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.

PiRK mentioned this in D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.Sep 30 2025, 14:02

PiRK mentioned this in rABCeaee44f769d1: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.Sep 30 2025, 14:34

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-mempool-coherence-on-activations.py

2 lines

abc-schnorr.py

4 lines

abc-schnorrmultisig.py

8 lines

abc-transaction-ordering.py

2 lines

abc_p2p_avalanche_transaction_voting.py

4 lines

abc_wallet_standardness.py

2 lines

chronik_block_txs.py

17 lines

chronik_disable_token_index.py

8 lines

chronik_lokad_id_group.py

141 lines

chronik_mempool_conflicts.py

12 lines

chronik_mempool_disconnectpool.py

6 lines

chronik_pause.py

18 lines

chronik_plugins.py

52 lines

chronik_script_history.py

4 lines

chronik_script_unconfirmed_txs.py

2 lines

chronik_spent_by.py

2 lines

chronik_token_alp.py

52 lines

chronik_token_broadcast_txs.py

34 lines

chronik_token_burn.py

22 lines

chronik_token_id_group.py

26 lines

chronik_token_script_group.py

18 lines

chronik_token_slp_fungible.py

12 lines

chronik_token_slp_mint_vault.py

6 lines

chronik_token_slp_nft1.py

14 lines

chronik_tx.py

4 lines

chronik_ws_script.py

10 lines

feature_assumeutxo.py

2 lines

feature_bip68_sequence.py

28 lines

feature_block.py

9 lines

feature_cltv.py

4 lines

feature_csv_activation.py

4 lines

feature_dersig.py

2 lines

feature_utxo_set_hash.py

4 lines

2 lines

46 lines

10 lines

4 lines

4 lines

p2p_opportunistic_1p1c.py

10 lines

p2p_orphan_handling.py

4 lines

p2p_permissions.py

4 lines

rpc_packages.py

12 lines

test_framework/

blocktools.py

2 lines

chronik/

2 lines

11 lines

10 lines

2 lines

Diff 55997

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_wallet_standardness.py

View Options

test/functional/chronik_block_txs.py

View Options

test/functional/chronik_disable_token_index.py

View Options

test/functional/chronik_lokad_id_group.py

View Options

test/functional/chronik_mempool_conflicts.py

View Options

test/functional/chronik_mempool_disconnectpool.py

View Options

test/functional/chronik_pause.py

View Options

test/functional/chronik_plugins.py

View Options

test/functional/chronik_script_history.py

View Options

test/functional/chronik_script_unconfirmed_txs.py

View Options

test/functional/chronik_spent_by.py

View Options

test/functional/chronik_token_alp.py

View Options

test/functional/chronik_token_broadcast_txs.py

View Options

test/functional/chronik_token_burn.py

View Options

test/functional/chronik_token_id_group.py

View Options

test/functional/chronik_token_script_group.py

View Options

test/functional/chronik_token_slp_fungible.py

View Options

test/functional/chronik_token_slp_mint_vault.py

View Options

test/functional/chronik_token_slp_nft1.py

View Options

test/functional/chronik_tx.py

View Options

test/functional/chronik_ws_script.py

View Options

test/functional/feature_assumeutxo.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_utxo_set_hash.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_accept.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak_tx.py

View Options

test/functional/p2p_opportunistic_1p1c.py

View Options

test/functional/p2p_orphan_handling.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/rpc_packages.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/chronik/token_tx.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/p2p.py

View Options

test/functional/test_framework/wallet.py

test: rename CTransaction .rehash()/.hash -> .txid_hex for consistencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 55997

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc-transaction-ordering.py

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/abc_wallet_standardness.py

test/functional/chronik_block_txs.py

test/functional/chronik_disable_token_index.py

test/functional/chronik_lokad_id_group.py

test/functional/chronik_mempool_conflicts.py

test/functional/chronik_mempool_disconnectpool.py

test/functional/chronik_pause.py

test/functional/chronik_plugins.py

test/functional/chronik_script_history.py

test/functional/chronik_script_unconfirmed_txs.py

test/functional/chronik_spent_by.py

test/functional/chronik_token_alp.py

test/functional/chronik_token_broadcast_txs.py

test/functional/chronik_token_burn.py

test/functional/chronik_token_id_group.py

test/functional/chronik_token_script_group.py

test/functional/chronik_token_slp_fungible.py

test/functional/chronik_token_slp_mint_vault.py

test/functional/chronik_token_slp_nft1.py

test/functional/chronik_tx.py

test/functional/chronik_ws_script.py

test/functional/feature_assumeutxo.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_cltv.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/feature_utxo_set_hash.py

test/functional/interface_zmq.py

test/functional/mempool_accept.py

test/functional/p2p_compactblocks.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_leak_tx.py

test/functional/p2p_opportunistic_1p1c.py

test/functional/p2p_orphan_handling.py

test/functional/p2p_permissions.py

test/functional/rpc_packages.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/chronik/token_tx.py

test/functional/test_framework/messages.py

test/functional/test_framework/p2p.py

test/functional/test_framework/wallet.py

test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency
ClosedPublic
Actions

Revision Contents
Changeset List