Page MenuHomePhabricator
Differential D18711

test: remove unused code from p2p_compactblocks
ClosedPublic
Actions

Authored by PiRK on Sep 29 2025, 13:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfe4ce9642e82: test: remove unused code from p2p_compactblocks
Summary

This code is unused since D1172 (we used to check that the tx didn't have a witness)

Also remove comments reffering to code that was removed in D1611 and D3814

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2025, 13:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2025, 13:20
PiRK requested review of this revision.Sep 29 2025, 13:20
PiRK updated this revision to Diff 55942.Sep 29 2025, 13:29
PiRK edited the summary of this revision. (Show Details)

also remove a comment that no longer makes sense

PiRK updated this revision to Diff 55943.Sep 29 2025, 13:33

more

PiRK edited the summary of this revision. (Show Details)Sep 29 2025, 13:33
Harbormaster completed remote builds in B34643: Diff 55941.Sep 29 2025, 13:39
Harbormaster completed remote builds in B34644: Diff 55942.Sep 29 2025, 13:46
Harbormaster completed remote builds in B34645: Diff 55943.Sep 29 2025, 13:53
PiRK added a child revision: D18712: test: remove txid caching in CTransaction class.Sep 29 2025, 15:33
Fabien accepted this revision.Sep 29 2025, 19:28
This revision is now accepted and ready to land.Sep 29 2025, 19:28
Closed by commit rABCfe4ce9642e82: test: remove unused code from p2p_compactblocks (authored by PiRK). · Explain WhySep 30 2025, 09:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCfe4ce9642e82: test: remove unused code from p2p_compactblocks.

Revision Contents
Changeset List

Diff 55994

View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/p2p_compactblocks.py

Loading...