HomePhabricator

[ecash-agora] Upgrade historicOffers to return token amounts purchased (and…

Description

[ecash-agora] Upgrade historicOffers to return token amounts purchased (and price)

Summary:
We are currently returning the amount from the input. This only matches the amount purchased if a user purchased all offered tokens.

What we really want is the amount purchased and the amount paid for that purchase. We are getting the txs in this method already, so the info is available. This is the point of the stack where we should solve this problem.

Note that the historicOffers method is not currently tested.

Test Plan: npm test

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: tobias_ruck, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D17422

Details

Provenance
bytesofmanAuthored on Sun, Dec 29, 18:45
bytesofmanPushed on Mon, Jan 13, 22:08
Reviewer
Restricted Project
Differential Revision
D17422: [ecash-agora] Upgrade historicOffers to return token amounts purchased (and price)
Parents
rABC1c0e73e93ef7: [avalanche] Set vote status for highest ranking contender
Branches
Unknown
Tags
Unknown