HomePhabricator

Disable CWalletTx copy constructor

Description

Disable CWalletTx copy constructor

Summary:
Disable copying of CWalletTx objects to prevent bugs where instances get copied
in and out of the mapWallet map and fields are updated in the wrong copy.

This is a backport of Core PR9381 [4/5]
https://github.com/bitcoin/bitcoin/pull/9381/commits/d002f9d15d938e78360ad906f2d74a249c7e923e
Depends on D9076

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9077

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Jan 27 2021, 16:35
PiRKCommitted on Jan 27 2021, 16:36
abc-botPushed on Jan 27 2021, 16:42
Reviewer
Restricted Project
Differential Revision
D9077: Disable CWalletTx copy constructor
Parents
rABC6bde49b66858: Avoid copying CWalletTx in LoadToWallet
Branches
Unknown
Tags
Unknown