HomePhabricator

[backport#14783] qt: Call noui_connect to prevent boost::signals2…

Description

[backport#14783] qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning

Summary:
Merge bitcoin#14783: gui: Fix boost::signals2::no_slots_error in early calls to InitWarning

6bbdb20 squashme: connect thru node interface (João Barbosa)
a0f8df3 qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning (João Barbosa)

Pull request description:

Adding the following to bitcoin.conf

[xxx]
disablewallet=1

And running bitcoin-qt gives:

libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::signals2::no_slots_error> >: boost::signals2::no_slots_error

Fixes regression in bitcoin#14708.


This is a backport of Core PR14783

Test Plan:

ninja check
BITCOIND={full_path_to_build_dir}/src/qt/bitcoin-qt ./test/functional/test_runner.py feature_config_args feature_includeconf

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5794

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on Nov 22 2018, 17:40
majcostaCommitted on Apr 22 2020, 19:08
majcostaPushed on Apr 22 2020, 19:08
Reviewer
Restricted Project
Differential Revision
D5794: [backport#14783] qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning
Parents
rABC7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls
Branches
Unknown
Tags
Unknown