Page MenuHomePhabricator
Differential D5794

[backport#14783] qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning
ClosedPublic
Actions

Authored by majcosta on Apr 21 2020, 04:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1b7b18cbca53: [backport#14783] qt: Call noui_connect to prevent boost::signals2…
rABC1b7b18cbca53: [backport#14783] qt: Call noui_connect to prevent boost::signals2…
Summary

Merge bitcoin#14783: gui: Fix boost::signals2::no_slots_error in early calls to InitWarning

6bbdb20 squashme: connect thru node interface (João Barbosa)
a0f8df3 qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning (João Barbosa)

Pull request description:

Adding the following to bitcoin.conf

[xxx]
disablewallet=1

And running bitcoin-qt gives:

libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::signals2::no_slots_error> >: boost::signals2::no_slots_error

Fixes regression in bitcoin#14708.

This is a backport of Core PR14783

Test Plan
ninja check
BITCOIND={full_path_to_build_dir}/src/qt/bitcoin-qt ./test/functional/test_runner.py feature_config_args feature_includeconf

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 21 2020, 04:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 04:32
teamcity edited the summary of this revision. (Show Details)Apr 21 2020, 04:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 21 2020, 04:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 21 2020, 04:33
teamcity added a comment.Apr 21 2020, 04:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10330: Diff 18992.Apr 21 2020, 04:44
Fabien requested changes to this revision.Apr 21 2020, 07:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoingui.cpp
16 ↗(On Diff #18992)

The removal of #include <noui.h> is missing.

This revision now requires changes to proceed.Apr 21 2020, 07:56
majcosta updated this revision to Diff 18994.Apr 21 2020, 08:50

removed noui.h from bitcoingui.cpp

teamcity added a comment.Apr 21 2020, 08:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.Apr 21 2020, 09:12
This revision is now accepted and ready to land.Apr 21 2020, 09:12
teamcity added a comment.Apr 21 2020, 09:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10331: Diff 18994.Apr 21 2020, 09:12
majcosta added a child revision: D5807: [backport#16366] init: Use InitError for all errors in bitcoind/qt.Apr 22 2020, 18:47
Closed by commit rABC1b7b18cbca53: [backport#14783] qt: Call noui_connect to prevent boost::signals2… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyApr 22 2020, 19:08
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1b7b18cbca53: [backport#14783] qt: Call noui_connect to prevent boost::signals2….
majcosta added a commit: rSTAGING1b7b18cbca53: [backport#14783] qt: Call noui_connect to prevent boost::signals2….May 5 2020, 19:04

Revision Contents
Changeset List

PathSize
src/
qt/
16 lines
4 lines

Diff 19026

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...