Page MenuHomePhabricator
Differential D5807

[backport#16366] init: Use InitError for all errors in bitcoind/qt
ClosedPublic
Actions

Authored by majcosta on Apr 22 2020, 18:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc5a632bec6c9: [backport#16366] init: Use InitError for all errors in bitcoind/qt
rABCc5a632bec6c9: [backport#16366] init: Use InitError for all errors in bitcoind/qt
Summary

Pull Request#16366

fa6f402bde146f92ed131e0c9c8e15a55e723307 Call node->initError instead of InitError from GUI code (Russell Yanofsky)
fad2502240a1c440ef03ac3f880475702e418275 init: Use InitError for all errors in bitcoind/qt (MarcoFalke)

Description:

Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: (N.f.B: Depends on D5794)

sh
BITCOIND=bitcoin-qt ./test/functional/test_runner.py feature_includeconf feature_config_args

Pull Request#15864

ffea41f5301d5582665cf10ba5c2b9547a1443de Enable all tests in feature_config_args.py (Hennadii Stepanov)

Description:

Fix broken feature_config_args.py tests (disabled by MarcoFalke@fabe28a0cdcfa13e0e595a0905e3642a960d3077). All test are enabled now.

This is a backport of Core PR16366 with a partial backport of core PR15864

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 22 2020, 18:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2020, 18:47
teamcity edited the summary of this revision. (Show Details)Apr 22 2020, 18:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 22 2020, 18:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10349: Diff 19023.Apr 22 2020, 19:00
teamcity added a comment.Apr 22 2020, 19:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix requested changes to this revision.Apr 22 2020, 20:28

Almost good, you messed up a header.

src/bitcoind.cpp
28 ↗(On Diff #19023)

Remove

This revision now requires changes to proceed.Apr 22 2020, 20:28
majcosta updated this revision to Diff 19033.Apr 22 2020, 20:48

removed spurious cstdio header

teamcity added a comment.Apr 22 2020, 20:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 22 2020, 21:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10357: Diff 19033.Apr 22 2020, 21:13
deadalnix accepted this revision.Apr 22 2020, 21:51
This revision is now accepted and ready to land.Apr 22 2020, 21:51
majcosta added a child revision: D5812: [backport#15864] Fix datadir handling.Apr 22 2020, 22:07
Closed by commit rABCc5a632bec6c9: [backport#16366] init: Use InitError for all errors in bitcoind/qt (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyApr 22 2020, 22:10
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc5a632bec6c9: [backport#16366] init: Use InitError for all errors in bitcoind/qt.
majcosta added a commit: rSTAGINGc5a632bec6c9: [backport#16366] init: Use InitError for all errors in bitcoind/qt.May 5 2020, 19:05

Revision Contents
Changeset List

PathSize
src/
47 lines
interfaces/
3 lines
3 lines
qt/
1 line
15 lines
test/
functional/
20 lines
6 lines

Diff 19045

View Options

src/bitcoind.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

test/functional/feature_config_args.py

Loading...
View Options

test/functional/feature_includeconf.py

Loading...