Page MenuHomePhabricator

[backport#16366] init: Use InitError for all errors in bitcoind/qt
ClosedPublic

Authored by majcosta on Apr 22 2020, 18:47.

Details

Summary

Pull Request#16366

fa6f402bde146f92ed131e0c9c8e15a55e723307 Call node->initError instead of InitError from GUI code (Russell Yanofsky)
fad2502240a1c440ef03ac3f880475702e418275 init: Use InitError for all errors in bitcoind/qt (MarcoFalke)

Description:

Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: (N.f.B: Depends on D5794)

sh
BITCOIND=bitcoin-qt ./test/functional/test_runner.py feature_includeconf feature_config_args

Pull Request#15864

ffea41f5301d5582665cf10ba5c2b9547a1443de Enable all tests in feature_config_args.py (Hennadii Stepanov)

Description:

Fix broken feature_config_args.py tests (disabled by MarcoFalke@fabe28a0cdcfa13e0e595a0905e3642a960d3077). All test are enabled now.


This is a backport of Core PR16366 with a partial backport of core PR15864

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 22 2020, 20:28

Almost good, you messed up a header.

src/bitcoind.cpp
28 ↗(On Diff #19023)

Remove

This revision now requires changes to proceed.Apr 22 2020, 20:28

removed spurious cstdio header

This revision is now accepted and ready to land.Apr 22 2020, 21:51