HomePhabricator

Accept unrequested blocks with work equal to our tip

Authored by Matt Corallo <git@bluematt.me> on Jan 5 2019, 02:48.

Description

Accept unrequested blocks with work equal to our tip

Summary:
This is a simple change that makes our accept requirements the
same as our request requirements, (ever so slightly) further
decoupling our consensus logic from our FindNextBlocksToDownload
logic in net_processing.

Partial backport of Core PR 11531 (932f118)
https://github.com/bitcoin/bitcoin/pull/11531/commits/932f118e6a3779bb3d6c3cc83963cf34ac150e42

This looks safe to me since it does not introduce any DoS vector beyond what currently exists.

Test Plan: test_runner.py --extended

Reviewers: deadalnix, Fabien, #bitcoin_abc

Reviewed By: deadalnix, Fabien, #bitcoin_abc

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2254

Details

Committed
jasonbcoxJan 5 2019, 17:40
Pushed
jasonbcoxJan 5 2019, 17:40
Reviewer
Restricted Project
Differential Revision
D2254: Accept unrequested blocks with work equal to our tip
Parents
rABCa63d876edb6f: Cleanup configure.ac to remove old boost versions workarounds
Branches
Unknown
Tags
Unknown

Event Timeline