Page MenuHomePhabricator

Accept unrequested blocks with work equal to our tip
ClosedPublic

Authored by jasonbcox on Jan 5 2019, 02:45.

Details

Summary

This is a simple change that makes our accept requirements the
same as our request requirements, (ever so slightly) further
decoupling our consensus logic from our FindNextBlocksToDownload
logic in net_processing.

Partial backport of Core PR 11531 (932f118)
https://github.com/bitcoin/bitcoin/pull/11531/commits/932f118e6a3779bb3d6c3cc83963cf34ac150e42

This looks safe to me since it does not introduce any DoS vector beyond what currently exists.

Test Plan

test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Jan 5 2019, 02:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2019, 02:45
Herald added a subscriber: schancel. · View Herald Transcript
Fabien accepted this revision as: Fabien.Jan 5 2019, 14:27
This revision is now accepted and ready to land.Jan 5 2019, 14:27
deadalnix accepted this revision.Jan 5 2019, 17:26
This revision was automatically updated to reflect the committed changes.

Progress towards T456