Accept unrequested blocks with work equal to our tip
ClosedPublic
Actions

Authored by jasonbcox on Jan 5 2019, 02:45.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING1b979d882ffa: Accept unrequested blocks with work equal to our tip
rABC1b979d882ffa: Accept unrequested blocks with work equal to our tip

Summary

This is a simple change that makes our accept requirements the
same as our request requirements, (ever so slightly) further
decoupling our consensus logic from our FindNextBlocksToDownload
logic in net_processing.

Partial backport of Core PR 11531 (932f118)
https://github.com/bitcoin/bitcoin/pull/11531/commits/932f118e6a3779bb3d6c3cc83963cf34ac150e42

This looks safe to me since it does not introduce any DoS vector beyond what currently exists.

Test Plan

test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jan 5 2019, 02:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2019, 02:45

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4415: Diff 6510.Jan 5 2019, 02:55

Fabien accepted this revision as: Fabien.Jan 5 2019, 14:27

This revision is now accepted and ready to land.Jan 5 2019, 14:27

deadalnix accepted this revision.Jan 5 2019, 17:26

Closed by commit rABC1b979d882ffa: Accept unrequested blocks with work equal to our tip (authored by Matt Corallo <git@bluematt.me>, committed by jasonbcox). · Explain WhyJan 5 2019, 17:40

This revision was automatically updated to reflect the committed changes.

Progress towards T456

jasonbcox mentioned this in D1977: Merge #11531: Check that new headers are not a descendant of an invalid block (more effeciently).Mar 5 2019, 00:36

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

6 lines

test/

functional/

p2p-acceptblock.py

15 lines

Diff 6514

View Options

src/validation.cpp