HomePhabricator
Diffusion Bitcoin ABC 1e0b4b7e66a8

Remove AcceptToMemoryPoolWithTime default args
1e0b4b7e66a8
Actions

Description

Remove AcceptToMemoryPoolWithTime default args

Summary:
Backport D1041 missed converting AcceptToMemoryPoolWithTime to not use
default args, presumably due to merge conflict with D348.

This backports to like PR10201, to be explicit like in Core (as it is
to this day).

Also restored inline /* */ comments in the LoadMempool callsite, as there are a lot of mystery parameters.

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3093

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on May 23 2019, 14:14
markblundebergPushed on May 23 2019, 14:14
Reviewer
Restricted Project
Differential Revision
D3093: Remove AcceptToMemoryPoolWithTime default args
Parents
rABC774fa3ffdde6: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).May 23 2019, 14:14
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added an edge: D3093: Remove AcceptToMemoryPoolWithTime default args.

Changes (1)

PathSize
src/

rABC1e0b4b7e66a8

View Options

src/validation.cpp

Loading...