Page MenuHomePhabricator

Remove AcceptToMemoryPoolWithTime default args
ClosedPublic

Authored by markblundeberg on Wed, May 22, 20:50.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args
Summary

Backport D1041 missed converting AcceptToMemoryPoolWithTime to not use
default args, presumably due to merge conflict with D348.

This backports to like PR10201, to be explicit like in Core (as it is
to this day).

Also restored inline /* */ comments in the LoadMempool callsite, as there are a lot of mystery parameters.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Wed, May 22, 20:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 22, 20:50
markblundeberg planned changes to this revision.Wed, May 22, 20:58
markblundeberg edited the summary of this revision. (Show Details)Wed, May 22, 21:11
markblundeberg updated this revision to Diff 8810.

more accurate description; add comments

markblundeberg retitled this revision from Revert AcceptToMemoryPoolWithTime default args customization to Remove AcceptToMemoryPoolWithTime default args.Wed, May 22, 21:18
deadalnix accepted this revision.Thu, May 23, 11:59
This revision is now accepted and ready to land.Thu, May 23, 11:59