Merge #11742: rpc: Add testmempoolaccept
Summary:
PR11742 backport https://github.com/bitcoin/bitcoin/pull/11742/files
b55555d rpc: Add testmempoolaccept (MarcoFalke)
also follow-up mini PR
PR12860 backport https://github.com/bitcoin/bitcoin/pull/12860/files
fafcad3 doc: Add testmempoolaccept to release-notes (MarcoFalke)
Pull request description:
To check if a single raw transaction makes it into the current transaction pool, one had to call `sendrawtransaction`. However, on success, this adds the transaction to the mempool with no easy way to undo. The call `testmempoolaccept` is introduced to provide a way to solely check the result without changing the mempool state.
Modifications for ABC:
- include fLimitFree param (like sendrawtransaction) and remove RBF
- adapt rpc tests:
- no RBF test
- +1 input in large transaction test (to ensure OVER 1 MB)
- rpc messages "bad-tx-coinbase" and "bad-txns-nonfinal"
Depends on D3075 and D3078 and D3093
Test Plan:
make check
test_runner.py
Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix
Reviewed By: #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D3079