Page MenuHomePhabricator
Differential D3079

Merge #11742: rpc: Add testmempoolaccept
ClosedPublic
Actions

Authored by markblundeberg on May 21 2019, 01:34.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING178c19ea251e: Merge #11742: rpc: Add testmempoolaccept
rABC178c19ea251e: Merge #11742: rpc: Add testmempoolaccept
Summary

PR11742 backport https://github.com/bitcoin/bitcoin/pull/11742/files
b55555d rpc: Add testmempoolaccept (MarcoFalke)

also follow-up mini PR
PR12860 backport https://github.com/bitcoin/bitcoin/pull/12860/files
fafcad3 doc: Add testmempoolaccept to release-notes (MarcoFalke)

Pull request description:

To check if a single raw transaction makes it into the current transaction pool, one had to call `sendrawtransaction`. However, on success, this adds the transaction to the mempool with no easy way to undo.

The call `testmempoolaccept` is introduced to provide a way to solely check the result without changing the mempool state.

Modifications for ABC:

  • include fLimitFree param (like sendrawtransaction) and remove RBF
  • adapt rpc tests:
    • no RBF test
    • +1 input in large transaction test (to ensure OVER 1 MB)
    • rpc messages "bad-tx-coinbase" and "bad-txns-nonfinal"

Depends on D3075 and D3078 and D3093

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 21 2019, 01:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2019, 01:34
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 21 2019, 01:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 21 2019, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5917: Diff 8768.May 21 2019, 01:49
markblundeberg added a child revision: D3080: Merge #13527: policy: Remove promiscuousmempoolflags.May 21 2019, 06:14
markblundeberg updated this revision to Diff 8772.May 21 2019, 06:24

incorporate small follow-up PR12860 too

teamcity added a comment.May 21 2019, 06:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)May 21 2019, 06:25
markblundeberg edited the summary of this revision. (Show Details)
teamcity added a comment.May 21 2019, 06:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5921: Diff 8772.May 21 2019, 06:39
deadalnix requested changes to this revision.May 22 2019, 00:00
deadalnix added inline comments.
src/validation.cpp
825 ↗(On Diff #8772)

There is one other callsite, so it might be worth making the code similar to core instead of adding more customization.

This revision now requires changes to proceed.May 22 2019, 00:00
markblundeberg updated this revision to Diff 8811.May 22 2019, 21:16
markblundeberg marked an inline comment as done.
markblundeberg edited the summary of this revision. (Show Details)

address comment: rebase onto D3093

teamcity added a comment.May 22 2019, 21:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg updated this revision to Diff 8812.May 22 2019, 21:17

oops, dropped a comment

teamcity added a comment.May 22 2019, 21:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 22 2019, 21:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5943: Diff 8811.May 22 2019, 21:31
Harbormaster completed remote builds in B5944: Diff 8812.
teamcity added a comment.May 22 2019, 21:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a parent revision: D3093: Remove AcceptToMemoryPoolWithTime default args.May 23 2019, 00:27
deadalnix accepted this revision.May 23 2019, 15:31
This revision is now accepted and ready to land.May 23 2019, 15:31
Closed by commit rABC178c19ea251e: Merge #11742: rpc: Add testmempoolaccept (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 23 2019, 17:02
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC178c19ea251e: Merge #11742: rpc: Add testmempoolaccept.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING178c19ea251e: Merge #11742: rpc: Add testmempoolaccept.Sep 18 2019, 23:43
markblundeberg mentioned this in D4796: Backport PR11309: Minor cleanups for AcceptToMemoryPool.Dec 22 2019, 03:46
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool.Dec 23 2019, 02:08
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool.Apr 7 2020, 22:14

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
rpc/
2 lines
88 lines
3 lines
47 lines
test/
functional/
325 lines
test_framework/
1 line

Diff 8833

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...