Page MenuHomePhabricator

Merge #11877: Improve createrawtransaction functional tests

Authored by markblundeberg on May 20 2019, 07:28.



PR11877 backport

  • for "vout must be a number" ABC error message
  • remove stuff related to RBF

88af502 test: Add createrawtransaction functional tests (João Barbosa)
27c6199 test: Add multidict to support dictionary with duplicate key (laanwj) (João Barbosa)
320669a rpc: Validate replaceable type in createrawtransaction (João Barbosa)

Pull request description:

This was motivated by the `Invalid parameter, duplicated address` test.

Credit to @laanwj for `multidict` implementation.
Test Plan

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nb: needs to be re-linted apparently

Fabien requested changes to this revision.May 20 2019, 08:51
Fabien added a subscriber: Fabien.

Code looks good, can you run the linter an request for review again ?

106 ↗(On Diff #8738)

The linter adds a line break after format(.

This revision now requires changes to proceed.May 20 2019, 08:51
This revision is now accepted and ready to land.May 20 2019, 15:09