HomePhabricator

Merge #11877: Improve createrawtransaction functional tests

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Dec 13 2017, 16:12.

Description

Merge #11877: Improve createrawtransaction functional tests

Summary:
PR11877 backport https://github.com/bitcoin/bitcoin/pull/11877/files
modifications:

  • for "vout must be a number" ABC error message
  • remove stuff related to RBF

88af502 test: Add createrawtransaction functional tests (João Barbosa)
27c6199 test: Add multidict to support dictionary with duplicate key (laanwj) (João Barbosa)
320669a rpc: Validate replaceable type in createrawtransaction (João Barbosa)

Pull request description:

This was motivated by the `Invalid parameter, duplicated address` test.

Credit to @laanwj for `multidict` implementation.

Test Plan: test_runner.py

Reviewers: jasonbcox, #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Maniphest Tasks: T639

Differential Revision: https://reviews.bitcoinabc.org/D3072

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rSTAGING313eca342457: Merge #11877: Improve createrawtransaction functional tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).May 20 2019, 16:07