Page MenuHomePhabricator

Merge #11877: Improve createrawtransaction functional tests
ClosedPublic

Authored by markblundeberg on May 20 2019, 07:28.

Details

Summary

PR11877 backport https://github.com/bitcoin/bitcoin/pull/11877/files
modifications:

  • for "vout must be a number" ABC error message
  • remove stuff related to RBF

88af502 test: Add createrawtransaction functional tests (João Barbosa)
27c6199 test: Add multidict to support dictionary with duplicate key (laanwj) (João Barbosa)
320669a rpc: Validate replaceable type in createrawtransaction (João Barbosa)

Pull request description:

This was motivated by the `Invalid parameter, duplicated address` test.

Credit to @laanwj for `multidict` implementation.
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
crttests
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5901
Build 9862: Bitcoin ABC Buildbot (legacy)
Build 9861: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 20 2019, 07:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2019, 07:28

nb: needs to be re-linted apparently

Fabien requested changes to this revision.May 20 2019, 08:51
Fabien added a subscriber: Fabien.

Code looks good, can you run the linter an request for review again ?

test/functional/rpc_rawtransaction.py
106 ↗(On Diff #8738)

The linter adds a line break after format(.

This revision now requires changes to proceed.May 20 2019, 08:51
Fabien accepted this revision.May 20 2019, 15:09
This revision is now accepted and ready to land.May 20 2019, 15:09