Page MenuHomePhabricator
Differential D3072

Merge #11877: Improve createrawtransaction functional tests
ClosedPublic
Actions

Authored by markblundeberg on May 20 2019, 07:28.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T639: Backport Core PR 11877 (tests)
Commits
rSTAGING313eca342457: Merge #11877: Improve createrawtransaction functional tests
rABC313eca342457: Merge #11877: Improve createrawtransaction functional tests
Summary

PR11877 backport https://github.com/bitcoin/bitcoin/pull/11877/files
modifications:

  • for "vout must be a number" ABC error message
  • remove stuff related to RBF

88af502 test: Add createrawtransaction functional tests (João Barbosa)
27c6199 test: Add multidict to support dictionary with duplicate key (laanwj) (João Barbosa)
320669a rpc: Validate replaceable type in createrawtransaction (João Barbosa)

Pull request description:

This was motivated by the `Invalid parameter, duplicated address` test.

Credit to @laanwj for `multidict` implementation.
Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
crttests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5901
Build 9862: Bitcoin ABC Buildbot (legacy)
Build 9861: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 20 2019, 07:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2019, 07:28
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T639: Backport Core PR 11877 (tests).May 20 2019, 07:29
teamcity added a comment.May 20 2019, 07:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.May 20 2019, 07:31

nb: needs to be re-linted apparently

teamcity added a comment.May 20 2019, 07:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5898: Diff 8738.May 20 2019, 07:43
Fabien requested changes to this revision.May 20 2019, 08:51
Fabien added a subscriber: Fabien.

Code looks good, can you run the linter an request for review again ?

test/functional/rpc_rawtransaction.py
106 ↗(On Diff #8738)

The linter adds a line break after format(.

This revision now requires changes to proceed.May 20 2019, 08:51
markblundeberg updated this revision to Diff 8741.May 20 2019, 13:44

relint

teamcity added a comment.May 20 2019, 13:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 20 2019, 13:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5901: Diff 8741.May 20 2019, 13:58
markblundeberg updated this revision to Diff 8743.May 20 2019, 14:02

rebased for D3071

teamcity added a comment.May 20 2019, 14:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5902: Diff 8743.May 20 2019, 14:16
teamcity added a comment.May 20 2019, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 20 2019, 15:09
This revision is now accepted and ready to land.May 20 2019, 15:09
Closed by commit rABC313eca342457: Merge #11877: Improve createrawtransaction functional tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 20 2019, 16:07
This revision was automatically updated to reflect the committed changes.
markblundeberg added a child revision: D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.May 20 2019, 16:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING313eca342457: Merge #11877: Improve createrawtransaction functional tests.Sep 18 2019, 23:37

Revision Contents
Changeset List

PathSize
test/
functional/
69 lines

Diff 8741

View Options

test/functional/rpc_rawtransaction.py

Loading...