HomePhabricator

Merge #11742: rpc: Add testmempoolaccept

Description

Merge #11742: rpc: Add testmempoolaccept

Summary:
PR11742 backport https://github.com/bitcoin/bitcoin/pull/11742/files
b55555d rpc: Add testmempoolaccept (MarcoFalke)

also follow-up mini PR
PR12860 backport https://github.com/bitcoin/bitcoin/pull/12860/files
fafcad3 doc: Add testmempoolaccept to release-notes (MarcoFalke)

Pull request description:

To check if a single raw transaction makes it into the current transaction pool, one had to call `sendrawtransaction`. However, on success, this adds the transaction to the mempool with no easy way to undo.

The call `testmempoolaccept` is introduced to provide a way to solely check the result without changing the mempool state.

Modifications for ABC:

  • include fLimitFree param (like sendrawtransaction) and remove RBF
  • adapt rpc tests:
    • no RBF test
    • +1 input in large transaction test (to ensure OVER 1 MB)
    • rpc messages "bad-tx-coinbase" and "bad-txns-nonfinal"

Depends on D3075 and D3078 and D3093

Test Plan:
make check
test_runner.py

Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3079

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 23 2019, 16:50
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on May 23 2019, 17:02
markblundebergPushed on May 23 2019, 17:02
Reviewer
Restricted Project
Differential Revision
D3079: Merge #11742: rpc: Add testmempoolaccept
Parents
rABC1b5292777d9f: Refactor walletdb_tests to use the wallet test fixture
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC178c19ea251e: Merge #11742: rpc: Add testmempoolaccept (authored by Wladimir J. van der Laan <laanwj@gmail.com>).May 23 2019, 17:02