Page MenuHomePhabricator
Differential D3093

Remove AcceptToMemoryPoolWithTime default args
ClosedPublic
Actions

Authored by markblundeberg on May 22 2019, 20:50.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args
rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args
Summary

Backport D1041 missed converting AcceptToMemoryPoolWithTime to not use
default args, presumably due to merge conflict with D348.

This backports to like PR10201, to be explicit like in Core (as it is
to this day).

Also restored inline /* */ comments in the LoadMempool callsite, as there are a lot of mystery parameters.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
atmp-revert
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5942
Build 9944: Bitcoin ABC Buildbot (legacy)
Build 9943: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 22 2019, 20:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2019, 20:50
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 22 2019, 20:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg planned changes to this revision.May 22 2019, 20:58
teamcity added a comment.May 22 2019, 21:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5941: Diff 8809.May 22 2019, 21:05
markblundeberg updated this revision to Diff 8810.May 22 2019, 21:11
markblundeberg edited the summary of this revision. (Show Details)

more accurate description; add comments

teamcity added a comment.May 22 2019, 21:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in D3079: Merge #11742: rpc: Add testmempoolaccept.May 22 2019, 21:16
markblundeberg retitled this revision from Revert AcceptToMemoryPoolWithTime default args customization to Remove AcceptToMemoryPoolWithTime default args.May 22 2019, 21:18
teamcity added a comment.May 22 2019, 21:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5942: Diff 8810.May 22 2019, 21:27
markblundeberg added a child revision: D3079: Merge #11742: rpc: Add testmempoolaccept.May 23 2019, 00:27
markblundeberg added a reviewer: jasonbcox.May 23 2019, 02:29
deadalnix accepted this revision.May 23 2019, 11:59
This revision is now accepted and ready to land.May 23 2019, 11:59
Closed by commit rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 23 2019, 14:14
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC178c19ea251e: Merge #11742: rpc: Add testmempoolaccept.May 23 2019, 17:02
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args.Sep 18 2019, 23:41
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING178c19ea251e: Merge #11742: rpc: Add testmempoolaccept.Sep 18 2019, 23:43

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 8810

View Options

src/validation.cpp

Loading...