Page MenuHomePhabricator

Remove AcceptToMemoryPoolWithTime default args
ClosedPublic

Authored by markblundeberg on May 22 2019, 20:50.

Details

Summary

Backport D1041 missed converting AcceptToMemoryPoolWithTime to not use
default args, presumably due to merge conflict with D348.

This backports to like PR10201, to be explicit like in Core (as it is
to this day).

Also restored inline /* */ comments in the LoadMempool callsite, as there are a lot of mystery parameters.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
atmp-revert
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5942
Build 9944: Bitcoin ABC Buildbot (legacy)
Build 9943: arc lint + arc unit

Event Timeline

markblundeberg edited the summary of this revision. (Show Details)

more accurate description; add comments

markblundeberg retitled this revision from Revert AcceptToMemoryPoolWithTime default args customization to Remove AcceptToMemoryPoolWithTime default args.May 22 2019, 21:18
This revision is now accepted and ready to land.May 23 2019, 11:59