HomePhabricator

Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps…

Description

Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type

Summary:
203a4aa31 Fix CTxMemPoolEntry::UpdateAncestorState: modifySigOps param type int -> int64_t (donaloconnor)

Pull request description:

CTxMemPoolEntry::CTxMemPoolEntry's modifySigOps parameter is int while update_ancestor_state::modifySigOpsCost is int64_t. This issue was raised in #11165. It looks like the function paramaters were not changed in commit 72abd2c

This will avoid unexpected truncation of int64_t -> int

Tree-SHA512: 314c703f217e104336456859066d18fb0d12c4f9f32835e17490a6f29eb05951184095039e4e57edacef8ad35dd75c6d97d9af656a52209dd0c3779b4ffa0914

Backport of Core PR11269

Test Plan:

ninja check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5438

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 10 2017, 20:33
nakihitoCommitted on Mar 5 2020, 23:30
nakihitoPushed on Mar 5 2020, 23:30
Reviewer
Restricted Owners Package
Differential Revision
D5438: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type
Parents
rABC5f7aec629b38: Merge #14023: Remove accounts rpcs
Branches
Unknown
Tags
Unknown