Page MenuHomePhabricator
Differential D5438

Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type
ClosedPublic
Actions

Authored by nakihito on Mar 5 2020, 21:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps…
rABC1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps…
Summary

203a4aa31 Fix CTxMemPoolEntry::UpdateAncestorState: modifySigOps param type int -> int64_t (donaloconnor)

Pull request description:

CTxMemPoolEntry::CTxMemPoolEntry's modifySigOps parameter is int while update_ancestor_state::modifySigOpsCost is int64_t. This issue was raised in #11165. It looks like the function paramaters were not changed in commit 72abd2c

This will avoid unexpected truncation of int64_t -> int

Tree-SHA512: 314c703f217e104336456859066d18fb0d12c4f9f32835e17490a6f29eb05951184095039e4e57edacef8ad35dd75c6d97d9af656a52209dd0c3779b4ffa0914

Backport of Core PR11269

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 5 2020, 21:41
Owners added a reviewer: Restricted Owners Package.Mar 5 2020, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2020, 21:41
teamcity edited the summary of this revision. (Show Details)Mar 5 2020, 21:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 5 2020, 21:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 5 2020, 21:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9741: Diff 16784.Mar 5 2020, 21:52
deadalnix accepted this revision.Mar 5 2020, 23:13
This revision is now accepted and ready to land.Mar 5 2020, 23:13
Closed by commit rABC1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps… (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 5 2020, 23:30
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps….
nakihito added a commit: rSTAGING1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps….Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines

Diff 16790

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...