Page MenuHomePhabricator

Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type
ClosedPublic

Authored by nakihito on Mar 5 2020, 21:41.

Details

Summary

203a4aa31 Fix CTxMemPoolEntry::UpdateAncestorState: modifySigOps param type int -> int64_t (donaloconnor)

Pull request description:

CTxMemPoolEntry::CTxMemPoolEntry's modifySigOps parameter is int while update_ancestor_state::modifySigOpsCost is int64_t. This issue was raised in #11165. It looks like the function paramaters were not changed in commit 72abd2c

This will avoid unexpected truncation of int64_t -> int

Tree-SHA512: 314c703f217e104336456859066d18fb0d12c4f9f32835e17490a6f29eb05951184095039e4e57edacef8ad35dd75c6d97d9af656a52209dd0c3779b4ffa0914

Backport of Core PR11269

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11269
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9741
Build 17367: Default Diff Build & Tests
Build 17366: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 5 2020, 21:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mar 5 2020, 23:13