HomePhabricator

Use a different address in Avalanche test to prevent duplicate blocks

Description

Use a different address in Avalanche test to prevent duplicate blocks

Summary:
regtest blocks are relatively deterministic, so generating a block with the
same height, coinbase, timestamp, etc. may coincide with a block that was already generated.
In this case, it's possible to coincide with a block that was invalidated using the same
coinbase address above this line.

Test Plan:

test_runner.py abc-p2p-avalanche

Run this many times. On master, it's encountered ~10% of the time.
With this patch, we should not encounter it.

Note that abc-p2p-avalanche is still broken on master.

Reviewers: #bitcoin_abc, Fabien, deadalnix

Reviewed By: #bitcoin_abc, Fabien, deadalnix

Subscribers: deadalnix, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5691

Details

Provenance
jasonbcoxAuthored on Apr 9 2020, 17:32
jasonbcoxPushed on Apr 9 2020, 21:15
Reviewer
Restricted Project
Differential Revision
D5691: Use a different address in Avalanche test to prevent duplicate blocks
Parents
rABCf771ebd4b380: [backport] RPCAuth Detection in Logs
Branches
Unknown
Tags
Unknown