Page MenuHomePhabricator
Differential D5691

Use a different address in Avalanche test to prevent duplicate blocks
ClosedPublic
Actions

Authored by jasonbcox on Apr 9 2020, 17:37.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks
rABC22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks
Summary

regtest blocks are relatively deterministic, so generating a block with the
same height, coinbase, timestamp, etc. may coincide with a block that was already generated.
In this case, it's possible to coincide with a block that was invalidated using the same
coinbase address above this line.

Test Plan
test_runner.py abc-p2p-avalanche

Run this many times. On master, it's encountered ~10% of the time.
With this patch, we should not encounter it.

Note that abc-p2p-avalanche is still broken on master.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 9 2020, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2020, 17:37
teamcity added a comment.Apr 9 2020, 17:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox edited the test plan for this revision. (Show Details)Apr 9 2020, 17:38
teamcity added a comment.Apr 9 2020, 17:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10155: Diff 18709.Apr 9 2020, 17:48
Fabien added a subscriber: Fabien.Apr 9 2020, 17:57
Fabien added inline comments.
test/functional/abc-p2p-avalanche.py
177 ↗(On Diff #18709)

There is feature for that: fork_node.get_deterministic_priv_key().address

jasonbcox updated this revision to Diff 18710.Apr 9 2020, 18:05

Use get_deterministic_priv_key instead, as fork_node's deterministic key won't collide with node's

teamcity added a comment.Apr 9 2020, 18:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.Apr 9 2020, 18:06
This revision is now accepted and ready to land.Apr 9 2020, 18:06
deadalnix requested changes to this revision.Apr 9 2020, 18:13
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/abc-p2p-avalanche.py
84 ↗(On Diff #18710)

here

176 ↗(On Diff #18710)

Don't override the address variable.

This revision now requires changes to proceed.Apr 9 2020, 18:13
teamcity added a comment.Apr 9 2020, 18:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10156: Diff 18710.Apr 9 2020, 18:17
jasonbcox updated this revision to Diff 18711.Apr 9 2020, 18:34

Fixed overwriting the address variable. These are expected to be re-used in the future, so I
will not remove those variables outright.

teamcity added a comment.Apr 9 2020, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 9 2020, 18:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10157: Diff 18711.Apr 9 2020, 18:46
deadalnix accepted this revision.Apr 9 2020, 20:51
This revision is now accepted and ready to land.Apr 9 2020, 20:51
Closed by commit rABC22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks (authored by jasonbcox). · Explain WhyApr 9 2020, 21:15
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks.
jasonbcox added a commit: rSTAGING22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks.May 5 2020, 18:54

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 18712

View Options

test/functional/abc-p2p-avalanche.py

Loading...