Merge #13396: Drop unused arith_uint256 ! operator
23e7328f36eb
Actions

Description

Merge #13396: Drop unused arith_uint256 ! operator

Summary:
PR13396 backport https://github.com/bitcoin/bitcoin/pull/13396/files
2acd1d6716959b99e751cf85a7c47aaa383e937f Drop uint 256 not operator (Ben Woosley)

Pull request description:

All the other operators are integer or bitwise operations, and this is unused
apart from tests.

Note attempting to call `!` on `arith_uint256` results in a build error after this change:
```
test/arith_uint256_tests.cpp:201:17: error: invalid argument type 'const arith_uint256' to unary expression
    BOOST_CHECK(!ZeroL);
```

Test Plan: make check

Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3135

Details

Provenance

Wladimir J. van der Laan <laanwj@gmail.com>	Authored on Jun 7 2018, 17:21
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>	Committed on May 27 2019, 21:51
markblundeberg	Pushed on May 27 2019, 21:51

Reviewer

Restricted Project

Differential Revision

D3135: Merge #13396: Drop unused arith_uint256 ! operator

Parents

rABC47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests.

Branches

Unknown

Tags

Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC23e7328f36eb: Merge #13396: Drop unused arith_uint256 ! operator (authored by Wladimir J. van der Laan <laanwj@gmail.com>).May 27 2019, 21:51

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added an edge: D3135: Merge #13396: Drop unused arith_uint256 ! operator.