HomePhabricator

refactor: Change createWallet, fillPSBT argument order

Description

refactor: Change createWallet, fillPSBT argument order

Summary:
Move output arguments after input arguments for consistency with other methods,
and to work more easily with IPC framework in #10102

Backport of Core PR18278 part [5/6] : https://github.com/bitcoin/bitcoin/pull/18278/commits/1dca9dc4c772fa0a4ec52c4d88b7cd3d243aea7b

Depends on D8022

The Qt part of PSBT has not been ported so it is absent from this patch. This shouldn't be a problem, because it is a compilation error and trivial to fix, so it can be don then.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8023

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Dec 5 2017, 20:57
deadalnixCommitted on Oct 21 2020, 14:36
deadalnixPushed on Oct 21 2020, 14:36
Reviewer
Restricted Project
Differential Revision
D8023: refactor: Change createWallet, fillPSBT argument order
Parents
rABCba43817291fa: refactor: Change Chain::broadcastTransaction param order
Branches
Unknown
Tags
Unknown