Page MenuHomePhabricator

refactor: Change createWallet, fillPSBT argument order
ClosedPublic

Authored by deadalnix on Oct 21 2020, 13:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC24128015c5a1: refactor: Change createWallet, fillPSBT argument order
Summary

Move output arguments after input arguments for consistency with other methods,
and to work more easily with IPC framework in #10102

Backport of Core PR18278 part [5/6] : https://github.com/bitcoin/bitcoin/pull/18278/commits/1dca9dc4c772fa0a4ec52c4d88b7cd3d243aea7b

Depends on D8022

The Qt part of PSBT has not been ported so it is absent from this patch. This shouldn't be a problem, because it is a compilation error and trivial to fix, so it can be don then.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable