Differential D8020

refactor: Rename Node::disconnect methods
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2020, 13:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4f3e6494f3c4: refactor: Rename Node::disconnect methods

Summary

Avoid overloading method name to work more easily with IPC framework

Backport of Core PR18278 part [2/6] : https://github.com/bitcoin/bitcoin/pull/18278/commits/1c2ab1a6d29f2c6c065dae4f4a4e2ad1286311b3

Depends on D8019

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 21 2020, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 13:23

deadalnix requested review of this revision.Oct 21 2020, 13:23

teamcity edited the summary of this revision. (Show Details)Oct 21 2020, 13:23

deadalnix added a child revision: D8021: refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods.Oct 21 2020, 13:26

Harbormaster completed remote builds in B13555: Diff 24884.Oct 21 2020, 13:40

Fabien accepted this revision.Oct 21 2020, 13:51

This revision is now accepted and ready to land.Oct 21 2020, 13:51

Closed by commit rABC4f3e6494f3c4: refactor: Rename Node::disconnect methods (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 21 2020, 14:31

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4f3e6494f3c4: refactor: Rename Node::disconnect methods.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

node.h

4 lines

node.cpp

4 lines

qt/

rpcconsole.cpp

4 lines

Diff 24892

View Options

src/interfaces/node.h

View Options

src/interfaces/node.cpp

View Options

refactor: Rename Node::disconnect methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24892

src/interfaces/node.h

src/interfaces/node.cpp

src/qt/rpcconsole.cpp

refactor: Rename Node::disconnect methods
ClosedPublic
Actions

Revision Contents
Changeset List