rpc: Use RPCHelpMan for check-rpc-mappings linter
25e918ce936c
Actions

Description

rpc: Use RPCHelpMan for check-rpc-mappings linter

Summary:
This is a backport of core#20012 [2/3]
https://github.com/bitcoin/bitcoin/pull/20012/commits/fa92912b4bb4629addcbfdfb7cc000be701614af

Test Plan:
Update linters:
sudo arc liberate

Add errors in RPCHelpMan and make sure they are detected:

diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 8bb08769ec..770e8272e9 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -170,6 +170,7 @@ static const CRPCConvertParam vRPCConvertParams[] = {
     {"buildavalancheproof", 0, "sequence"},
     {"buildavalancheproof", 1, "expiration"},
     {"buildavalancheproof", 3, "stakes"},
+    {"buildavalancheproof", 4, "staks"},
 };

 class CRPCConvertTable {

diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 8bb08769ec..f883869060 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -168,7 +168,7 @@ static const CRPCConvertParam vRPCConvertParams[] = {
     // Avalanche
     {"addavalanchenode", 0, "nodeid"},
     {"buildavalancheproof", 0, "sequence"},
-    {"buildavalancheproof", 1, "expiration"},
+    {"buildavalancheproof", 8, "expiration"},
     {"buildavalancheproof", 3, "stakes"},
 };

ninja && test/functional/test_runner.py rpc_help

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10760