Page MenuHomePhabricator
Differential D10760

rpc: Use RPCHelpMan for check-rpc-mappings linter
ClosedPublic
Actions

Authored by PiRK on Jan 4 2022, 14:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC25e918ce936c: rpc: Use RPCHelpMan for check-rpc-mappings linter
Summary

This is a backport of core#20012 [2/3]
https://github.com/bitcoin/bitcoin/pull/20012/commits/fa92912b4bb4629addcbfdfb7cc000be701614af

Test Plan

Update linters:
sudo arc liberate

Add errors in RPCHelpMan and make sure they are detected:

diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 8bb08769ec..770e8272e9 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -170,6 +170,7 @@ static const CRPCConvertParam vRPCConvertParams[] = {
     {"buildavalancheproof", 0, "sequence"},
     {"buildavalancheproof", 1, "expiration"},
     {"buildavalancheproof", 3, "stakes"},
+    {"buildavalancheproof", 4, "staks"},
 };

 class CRPCConvertTable {
diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 8bb08769ec..f883869060 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -168,7 +168,7 @@ static const CRPCConvertParam vRPCConvertParams[] = {
     // Avalanche
     {"addavalanchenode", 0, "nodeid"},
     {"buildavalancheproof", 0, "sequence"},
-    {"buildavalancheproof", 1, "expiration"},
+    {"buildavalancheproof", 8, "expiration"},
     {"buildavalancheproof", 3, "stakes"},
 };

ninja && test/functional/test_runner.py rpc_help

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 4 2022, 14:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2022, 14:15
PiRK requested review of this revision.Jan 4 2022, 14:15
teamcity edited the summary of this revision. (Show Details)Jan 4 2022, 14:15
PiRK added a child revision: D10761: rpc: Remove duplicate name and argNames from CRPCCommand.Jan 4 2022, 14:17
Harbormaster completed remote builds in B17787: Diff 31624.Jan 4 2022, 14:36
Fabien added a subscriber: Fabien.Jan 4 2022, 15:49
Fabien added inline comments.
src/rpc/server.cpp
547 ↗(On Diff #31624)

Note that there is #21035 as a follow up

Fabien accepted this revision.Jan 4 2022, 16:01
This revision is now accepted and ready to land.Jan 4 2022, 16:01
PiRK added inline comments.Jan 4 2022, 16:58
src/rpc/server.cpp
547 ↗(On Diff #31624)

Thank you, I would have missed it. I will land both PR at the same time to minimize the risk of intermittent CI failure.

Fabien added a comment.Jan 4 2022, 19:06

You can land it now, it shouldn't be a problem

Closed by commit rABC25e918ce936c: rpc: Use RPCHelpMan for check-rpc-mappings linter (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 5 2022, 10:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC25e918ce936c: rpc: Use RPCHelpMan for check-rpc-mappings linter.

Revision Contents
Changeset List

PathSize
4 lines
arcanist/
2 lines
linter/
src/
rpc/
6 lines
15 lines
5 lines
17 lines
test/
functional/
73 lines
lint/

Diff 31641

View Options

.arclint

Loading...
View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/CheckRpcMappingsLinter.php

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

test/functional/rpc_help.py

Loading...
View Options

test/lint/check-rpc-mappings.py

Loading...