HomePhabricator

[Cashtab] Do not show new wallet msg for not-new wallets

Description

[Cashtab] Do not show new wallet msg for not-new wallets

Summary:
Users reporting toggling between 'congratulations new wallet' and normal wallet screen, on wallets with tx history.

Doing some digging, discovered it happened when parsedTxHistory was undefined.

This occurs when a new token is added to cache. The calling function is expecting info at the key parsedTxHistory, but this is not being returned

Test Plan:
npm start, receive a tx from a tokenId not in cache, do not see the 'new wallet' screen

Note: this patch is deployed to https://cashtab-local-dev.netlify.app/ and have gone through testing with Koush

Reviewers: #bitcoin_abc, Kronkmeister

Reviewed By: #bitcoin_abc, Kronkmeister

Differential Revision: https://reviews.bitcoinabc.org/D15442

Details

Provenance
bytesofmanAuthored on Feb 13 2024, 22:49
bytesofmanPushed on Feb 14 2024, 00:09
Reviewer
Restricted Project
Differential Revision
D15442: [Cashtab] Do not show new wallet msg for not-new wallets
Parents
rABC2079f57cab85: [chronik-client] Update chronikNode.ts proto file
Branches
Unknown
Tags
Unknown