HomePhabricator

doc: default minconf for getbalance should be 0

Description

doc: default minconf for getbalance should be 0

Summary:

  • Default minconf for getbalance is 0 but example in doc was showing as 1.
  • at least 6 blocks confirmed now updated to be at least 6 confirmations to be more consistent with the terminology used elsewhere in the codebase and documentations.

This is a backport of Core PR18502

Test Plan:
Check the new help message:

src/bitcoin-cli help getbalance

Check that the balance includes unconfirmed transactions by sending some fund to an external wallet and running immediately src/bitcoin-cli getbalance

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8924

Details

Provenance
U-Zyn Chua <chua@uzyn.com>Authored on Jan 15 2021, 10:27
PiRKCommitted on Jan 15 2021, 10:27
abc-botPushed on Jan 15 2021, 10:33
Reviewer
Restricted Project
Differential Revision
D8924: doc: default minconf for getbalance should be 0
Parents
rABC2dc004421409: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig
Branches
Unknown
Tags
Unknown