HomePhabricator

remove integer sanitizer suppression in validation.cpp

Description

remove integer sanitizer suppression in validation.cpp

Summary:
While looking at backporting core#24196, I noticed that the offending code was already changed in D359 (unsigned int -> size_t) and fixed in D1528 (removal of the for (size_t j = tx.vin.size(); j-- > 0;) loop)

Removing the file-wide suppression means that new UB can now be detected.

Test Plan:
With UBSAN
ninja && ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12821

Details

Provenance
PiRKAuthored on Dec 8 2022, 12:16
PiRKPushed on Dec 9 2022, 07:24
Reviewer
Restricted Project
Differential Revision
D12821: remove integer sanitizer suppression in validation.cpp
Parents
rABC32d5b6c9cfa2: test: Avoid testing negative block heights
Branches
Unknown
Tags
Unknown