Update ApplyBlockUndo to be able to undo out of order blocks.
ClosedPublic
Actions

Authored by deadalnix on Jul 1 2018, 16:00.

Details

Reviewers

schancel
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa0abcf8e3972: Update ApplyBlockUndo to be able to undo out of order blocks.
rABCa0abcf8e3972: Update ApplyBlockUndo to be able to undo out of order blocks.

Summary

As per title.

Test Plan

Updated integration test to check invalidation of blocks with out of orders transactions.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 1 2018, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2018, 16:00

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2781: Diff 4175.Jul 1 2018, 16:36

deadalnix added a parent revision: D1524: Various nits in validation.cpp.Jul 1 2018, 19:12

deadalnix added a child revision: D1529: Implement canonical transaction ordering..Jul 1 2018, 19:13

I don't think the title of this diff reflects what is going is being actually improved.

src/validation.cpp
1824 ↗	(On Diff #4175)	I don't understand this TXUndo stuff. Isn't it implied by the transaction itself? Why not generate this from CTransaction when needed?
1842 ↗	(On Diff #4175)	Why does changing the order allow this function to undo blocks out of order?
test/functional/abc-transaction-ordering.py
247 ↗	(On Diff #4175)	How does this test undoing blocks which are not in order?

This revision now requires changes to proceed.Jul 2 2018, 15:58

jasonbcox accepted this revision.Jul 2 2018, 16:03

I think you should dig in and understand these things. If I tell you "it does X" and then you accept the diff based on this, then the whole review process has no value.