HomePhabricator

Merge #10248: Rewrite addrdb with less duplication using CHashVerifier

Description

Merge #10248: Rewrite addrdb with less duplication using CHashVerifier

Summary:
PR10248 backport https://github.com/bitcoin/bitcoin/pull/10248/files
cf68a48 Deduplicate addrdb.cpp and use CHashWriter/Verifier (Pieter Wuille)

backport note: had to add chainParams everywhere due to ABC style; in
turn static had to be removed from one member function so addrdb.h remains
unmodified.

Test Plan: make check

Reviewers: deadalnix, jasonbcox, Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3582

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jun 22 2017, 17:40
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on Jul 8 2019, 14:07
markblundebergPushed on Jul 8 2019, 14:07
Reviewer
Restricted Project
Differential Revision
D3582: Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
Parents
rABC19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock()
Branches
Unknown
Tags
Unknown