Page MenuHomePhabricator

Merge #10248: Rewrite addrdb with less duplication using CHashVerifier
ClosedPublic

Authored by markblundeberg on Jul 7 2019, 20:08.

Details

Summary

PR10248 backport https://github.com/bitcoin/bitcoin/pull/10248/files
cf68a48 Deduplicate addrdb.cpp and use CHashWriter/Verifier (Pieter Wuille)

backport note: had to add chainParams everywhere due to ABC style; in
turn static had to be removed from one member function so addrdb.h remains
unmodified.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 7 2019, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 20:08
markblundeberg planned changes to this revision.Jul 7 2019, 20:10
markblundeberg added inline comments.
src/addrdb.cpp
48 ↗(On Diff #10055)

braces

52 ↗(On Diff #10055)

braces

57 ↗(On Diff #10055)

braces

101 ↗(On Diff #10055)

braces

Fabien accepted this revision.Jul 8 2019, 07:39
Fabien added inline comments.
src/addrdb.cpp
73 ↗(On Diff #10057)

Revert to uint8_t

This revision is now accepted and ready to land.Jul 8 2019, 07:39
markblundeberg marked an inline comment as done.Jul 8 2019, 14:08