Page MenuHomePhabricator

[2 of 5] validation: Extract basic block file logic into FlatFileSeq class.
ClosedPublic

Authored by markblundeberg on Sun, Jul 7, 21:55.

Details

Summary

partial PR15118 backport https://github.com/bitcoin/bitcoin/pull/15118/commits

This combines four refactor commits:
https://github.com/bitcoin/bitcoin/compare/9183d6ef6~1..e0380933e
...and a commit adding unit tests:
https://github.com/bitcoin/bitcoin/pull/15118/commits/4c01e4e159db82ce4b2acce75f709cac996367d7

These have been squashed due to intermediate commits not even building
properly. The tests have been modified to use CDiskBlockPos as the
rename is planned for a subsequent diff. Otherwise, it's the same.

Depends on D3579 D3583 D3584 D3585

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Sun, Jul 7, 21:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jul 7, 21:55
markblundeberg retitled this revision from [part 2 of 5] validation: Extract basic block file logic into FlatFileSeq class. to [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Sun, Jul 7, 21:55
markblundeberg planned changes to this revision.Sun, Jul 7, 22:14
markblundeberg added inline comments.
src/Makefile.am
255 ↗(On Diff #10063)

oops, this needs to go in CMakeLists too

CI failure from validation_block_tests, seems to be unrelated...

rebase because all parents are landed

jasonbcox requested changes to this revision.Wed, Jul 10, 19:26

Looks good otherwise.

src/flatfile.cpp
24 ↗(On Diff #10149)

brackets

75 ↗(On Diff #10149)

comment on previous line

This revision now requires changes to proceed.Wed, Jul 10, 19:26

address nits

deadalnix accepted this revision.Sun, Jul 14, 17:12
deadalnix added inline comments.
src/flatfile.cpp
5 ↗(On Diff #10276)

Standard lib include come last.

for include order (and rebuild)

jasonbcox accepted this revision.Tue, Jul 16, 14:50
This revision is now accepted and ready to land.Tue, Jul 16, 14:50