Page MenuHomePhabricator
Create Task
Maniphest T631

Backport PR 15118 "Refactor block file logic"
Closed, ResolvedPublic
Actions

Description

https://github.com/bitcoin/bitcoin/pull/15118

04cca3309 Style cleanup.
4c01e4e15 flatfile: Unit tests for FlatFileSeq methods.
65a489e93 scripted-diff: Rename CBlockDiskPos to FlatFilePos.
d6d8a78f2 Move CDiskBlockPos from chain to flatfile.
e0380933e validation: Refactor file flush logic into FlatFileSeq.
992404b31 validation: Refactor block file pre-allocation into FlatFileSeq.
e2d2abb99 validation: Refactor OpenDiskFile into method on FlatFileSeq.
9183d6ef6 validation: Extract basic block file logic into FlatFileSeq class.
62e7addb6 util: Move CheckDiskSpace to util.

Revisions and Commits

rABC Bitcoin ABC
ClosedD3589 [5 of 5] Style cleanup.
ClosedD3588 [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos.
ClosedD3587 [3 of 5] Move CDiskBlockPos from chain to flatfile.
ClosedD3586 [2 of 5] validation: Extract basic block file logic into FlatFileSeq class.
ClosedD3585 [1 of 5] util: Move CheckDiskSpace to util.

Related Objects
Search...

Event Timeline

markblundeberg triaged this task as Normal priority.May 5 2019, 02:45
markblundeberg created this task.
markblundeberg mentioned this in T589: BIP157 & BIP158 backports.
markblundeberg added a comment.EditedMay 6 2019, 01:19

T636 is needed for the new CheckDiskSpace mechanics to be upgraded cleanly

markblundeberg closed subtask T636: Backport PR 12653 "Allow to optional specify the directory for the blocks storage" as Resolved.May 10 2019, 02:44
markblundeberg added a comment.May 10 2019, 02:57

T648 too

markblundeberg added a subtask: T648: Backport PR 12806 qa: Fix function names in feature_blocksdir.May 10 2019, 02:57
markblundeberg edited subtasks, added: T630: Backport PR 13243 "Make reusable base class for auxiliary indices"; removed: T648: Backport PR 12806 qa: Fix function names in feature_blocksdir.May 21 2019, 00:51
markblundeberg closed subtask T630: Backport PR 13243 "Make reusable base class for auxiliary indices" as Resolved.Jun 19 2019, 15:38
markblundeberg added a comment.Jul 7 2019, 15:24

need:

Merge #11747: Fix: Open files read only if requested

markblundeberg added a revision: D3585: [1 of 5] util: Move CheckDiskSpace to util..Jul 7 2019, 21:56
markblundeberg added a revision: D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..
markblundeberg added a revision: D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..Jul 7 2019, 22:31
markblundeberg added a revision: D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..Jul 7 2019, 22:48
markblundeberg added a revision: D3589: [5 of 5] Style cleanup..Jul 7 2019, 23:06
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..Jul 9 2019, 18:43
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC47756d0eea51: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Jul 16 2019, 20:13
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCc2a03e1e9547: [3 of 5] Move CDiskBlockPos from chain to flatfile..Jul 19 2019, 15:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC2530507308ac: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..Aug 14 2019, 23:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCd181505a6b0f: [5 of 5] Style cleanup..Aug 15 2019, 00:01
markblundeberg closed this task as Resolved.Aug 15 2019, 00:01
markblundeberg claimed this task.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..Sep 19 2019, 01:06
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING47756d0eea51: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Sep 19 2019, 01:18
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGc2a03e1e9547: [3 of 5] Move CDiskBlockPos from chain to flatfile..Sep 19 2019, 01:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING2530507308ac: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..Sep 19 2019, 01:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGd181505a6b0f: [5 of 5] Style cleanup..