Page MenuHomePhabricator
Create Task
Maniphest T630

Backport PR 13243 "Make reusable base class for auxiliary indices"
Closed, ResolvedPublic
Actions

Description

https://github.com/bitcoin/bitcoin/pull/13243/files

ec3073a27 index: Move index DBs into index/ directory.
89eddcd36 index: Remove TxIndexDB from public interface of TxIndex.
2318affd2 MOVEONLY: Move BaseIndex to its own file.
f376a4924 index: Generalize logged statements in BaseIndex.
61a1226d8 index: Extract logic from TxIndex into reusable base class.
e5af5fc6f db: Make reusable base class for index databases.
9b0ec1a7f db: Remove obsolete methods from CBlockTreeDB.

also:

PR14085
ed12d5df1 index: Fix for indexers skipping genesis block.

Revisions and Commits

rABC Bitcoin ABC
ClosedD3310 Merge #14085: index: Fix for indexers skipping genesis block.
ClosedD2938 index: Move index DBs into index/ directory.
ClosedD2937 MOVEONLY: Move BaseIndex to its own file.
ClosedD2936 index: Generalize logged statements in BaseIndex.
ClosedD2935 index: Extract logic from TxIndex into reusable base class.
ClosedD2934 db: Make reusable base class for index databases.
ClosedD2933 db: Remove obsolete methods from CBlockTreeDB.

Related Objects
Search...

Event Timeline

markblundeberg triaged this task as Normal priority.May 5 2019, 01:41
markblundeberg created this task.
markblundeberg updated the task description. (Show Details)
markblundeberg mentioned this in T589: BIP157 & BIP158 backports.May 5 2019, 02:46
markblundeberg added a subtask: T617: Backport PR 13033 "Build txindex in parallel with validation".
markblundeberg added a comment.EditedMay 5 2019, 18:13

Last couple commits not happy here as they need T633 Need satisfied.

markblundeberg added a revision: D2933: db: Remove obsolete methods from CBlockTreeDB..May 5 2019, 20:12
markblundeberg added a revision: D2934: db: Make reusable base class for index databases..May 5 2019, 20:17
markblundeberg added a revision: D2935: index: Extract logic from TxIndex into reusable base class..May 5 2019, 20:27
markblundeberg added a revision: D2936: index: Generalize logged statements in BaseIndex..May 5 2019, 20:29
markblundeberg added a revision: D2937: MOVEONLY: Move BaseIndex to its own file..May 5 2019, 20:38
markblundeberg added a revision: D2938: index: Move index DBs into index/ directory..May 5 2019, 23:45
markblundeberg closed subtask T633: Backport PR 12731 "Support serialization as another type without casting" as Resolved.May 9 2019, 16:07
markblundeberg added a parent task: T631: Backport PR 15118 "Refactor block file logic".May 21 2019, 00:51
markblundeberg closed subtask T632: Backport PR 13106 "Simplify semantics of ChainStateFlushed callback" as Resolved.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC268f95c2f913: db: Remove obsolete methods from CBlockTreeDB..May 27 2019, 00:37
markblundeberg closed subtask T617: Backport PR 13033 "Build txindex in parallel with validation" as Resolved.May 27 2019, 04:06
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC4e92a9088431: db: Make reusable base class for index databases..May 28 2019, 16:00
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC3b2079b88dfb: index: Extract logic from TxIndex into reusable base class..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCfa0dbf7e7f10: index: Generalize logged statements in BaseIndex..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC99cbd491e734: MOVEONLY: Move BaseIndex to its own file..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCe06f70b4713e: index: Move index DBs into index/ directory..May 28 2019, 16:07
markblundeberg added a revision: D3310: Merge #14085: index: Fix for indexers skipping genesis block..Jun 13 2019, 02:08
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block..Jun 17 2019, 03:13
markblundeberg closed this task as Resolved.Jun 19 2019, 15:38
markblundeberg claimed this task.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING268f95c2f913: db: Remove obsolete methods from CBlockTreeDB..Sep 18 2019, 23:46
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING4e92a9088431: db: Make reusable base class for index databases..Sep 18 2019, 23:52
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING3b2079b88dfb: index: Extract logic from TxIndex into reusable base class..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGfa0dbf7e7f10: index: Generalize logged statements in BaseIndex..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING99cbd491e734: MOVEONLY: Move BaseIndex to its own file..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGe06f70b4713e: index: Move index DBs into index/ directory..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block..Sep 19 2019, 00:21