Paths

Table of Contentst

Differential D3310

Merge #14085: index: Fix for indexers skipping genesis block.
ClosedPublic
Actions

Authored by markblundeberg on Jun 13 2019, 02:07.

Tags

None

Subscribers

Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

T630: Backport PR 13243 "Make reusable base class for auxiliary indices"

Commits

rSTAGINGc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block.
rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block.

Summary

PR14085 backport https://github.com/bitcoin/bitcoin/pull/14085/files
ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 index: Fix for indexers skipping genesis block. (Jim Posen)

Pull request description:

This fixes a bug where indexers would skip processing of the genesis block. Preserves the current behavior of omitting genesis block transaction from the index.

Backporter note: indeed this changes nothing about current behaviour, it
just prepares for BIP157 filters that want to index the genesis.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jun 13 2019, 02:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 02:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".Jun 13 2019, 02:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6299: Diff 9373.Jun 13 2019, 02:14

Fabien requested changes to this revision.Jun 13 2019, 06:14

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/index/txindex.cpp
250 ↗	(On Diff #9373)	Braces
src/test/txindex_tests.cpp
6 ↗	(On Diff #9373)	Keep first on first place (on its own line to avoid the linter to reorder).
8 ↗	(On Diff #9373)	While you're at it, can you move this below this section ?

This revision now requires changes to proceed.Jun 13 2019, 06:14

address comments

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6309: Diff 9395.Jun 13 2019, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jun 13 2019, 22:23

deadalnix added inline comments.

src/test/txindex_tests.cpp
47 ↗	(On Diff #9395)	GetId . FindTx should take a TxId as parameter, not a uint256.

This revision now requires changes to proceed.Jun 13 2019, 22:23

markblundeberg marked an inline comment as done.Jun 13 2019, 23:40

markblundeberg added inline comments.

src/test/txindex_tests.cpp
47 ↗	(On Diff #9395)	OK; see D3329

use GetId

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6328: Diff 9419.Jun 13 2019, 23:47

Fabien accepted this revision.Jun 14 2019, 06:31

rebase for good measure

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6350: Diff 9454.Jun 14 2019, 18:34

deadalnix accepted this revision.Jun 15 2019, 23:10

This revision is now accepted and ready to land.Jun 15 2019, 23:10

Closed by commit rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 17 2019, 03:13

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block..

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGc3448655ec34: Merge #14085: index: Fix for indexers skipping genesis block..Sep 19 2019, 00:21

Revision Contents
Changeset List

Path

Size

src/

index/

6 lines

5 lines

test/

txindex_tests.cpp

11 lines

Diff 9489

src/index/base.cpp

Loading...

src/index/txindex.cpp

Loading...

src/test/txindex_tests.cpp

Loading...