Page MenuHomePhabricator

Merge #14085: index: Fix for indexers skipping genesis block.
ClosedPublic

Authored by markblundeberg on Jun 13 2019, 02:07.

Details

Summary

PR14085 backport https://github.com/bitcoin/bitcoin/pull/14085/files
ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 index: Fix for indexers skipping genesis block. (Jim Posen)

Pull request description:

This fixes a bug where indexers would skip processing of the genesis block. Preserves the current behavior of omitting genesis block transaction from the index.

Backporter note: indeed this changes nothing about current behaviour, it
just prepares for BIP157 filters that want to index the genesis.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Jun 13 2019, 06:14
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/index/txindex.cpp
250 ↗(On Diff #9373)

Braces

src/test/txindex_tests.cpp
6 ↗(On Diff #9373)

Keep first on first place (on its own line to avoid the linter to reorder).

8 ↗(On Diff #9373)

While you're at it, can you move this below this section ?

This revision now requires changes to proceed.Jun 13 2019, 06:14
deadalnix requested changes to this revision.Jun 13 2019, 22:23
deadalnix added inline comments.
src/test/txindex_tests.cpp
47 ↗(On Diff #9395)

GetId . FindTx should take a TxId as parameter, not a uint256.

This revision now requires changes to proceed.Jun 13 2019, 22:23
markblundeberg added inline comments.
src/test/txindex_tests.cpp
47 ↗(On Diff #9395)

OK; see D3329

markblundeberg marked an inline comment as done.

use GetId

This revision is now accepted and ready to land.Jun 15 2019, 23:10