Differential D3585

[1 of 5] util: Move CheckDiskSpace to util.
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 21:53.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T631: Backport PR 15118 "Refactor block file logic"

Commits

rSTAGINGdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util.
rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util.

Summary

partial PR15118 backport
https://github.com/bitcoin/bitcoin/pull/15118/commits/62e7addb632cad77cbd5fbccbaee51c7b32505d0

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jul 7 2019, 21:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 21:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..Jul 7 2019, 21:55

markblundeberg added a task: T631: Backport PR 15118 "Refactor block file logic".Jul 7 2019, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6717: Diff 10062.Jul 7 2019, 22:03

jasonbcox accepted this revision.Jul 8 2019, 18:53

This revision is now accepted and ready to land.Jul 8 2019, 18:53

Fabien added inline comments.Jul 8 2019, 20:26

src/util.cpp
207 ↗	(On Diff #10062)	Nit: move comment above

Closed by commit rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 9 2019, 18:42

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGdff115fc0b7e: [1 of 5] util: Move CheckDiskSpace to util..Sep 19 2019, 01:06

Revision Contents
Changeset List

			Path	Packages
M			src/init.cpp (4 lines)
M			src/util.h (1 line)
M			src/util.cpp (8 lines)
M			src/validation.h (8 lines)
M			src/validation.cpp (36 lines)

Diff 10146

src/init.cpp

Loading...

src/util.h

Loading...

src/util.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...