Page MenuHomePhabricator

jimpo (Jim Posen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2017, 23:53 (350 w, 1 d)

Recent Activity

May 20 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC8679dd55ea56: [index] Create new TxIndex class. (authored by jimpo).
[index] Create new TxIndex class.
May 20 2019, 23:10
jimpo closed D2904: [index] Create new TxIndex class..
May 20 2019, 23:10

May 6 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC8c7bbe889ce8: blockfilter: Use unordered_set instead of set in blockfilter. (authored by jimpo).
blockfilter: Use unordered_set instead of set in blockfilter.
May 6 2019, 22:37
jimpo closed D2926: blockfilter: Use unordered_set instead of set in blockfilter..
May 6 2019, 22:37

May 5 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC356dc81ee29e: [db] Migration for txindex data to new, separate database. (authored by jimpo).
[db] Migration for txindex data to new, separate database.
May 5 2019, 01:08
jimpo closed D2903: [db] Migration for txindex data to new, separate database..
May 5 2019, 01:08
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC258f89ed8b8b: [db] Create separate database for txindex. (authored by jimpo).
[db] Create separate database for txindex.
May 5 2019, 01:00
jimpo closed D2901: [db] Create separate database for txindex..
May 5 2019, 01:00

May 4 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction (authored by jimpo).
blockfilter: Refactor and add tests for BlockFilter construction
May 4 2019, 17:32
jimpo closed D2872: blockfilter: Refactor and add tests for BlockFilter construction.
May 4 2019, 17:32
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf1cf81504278: blockfilter: add block filters (authored by jimpo).
blockfilter: add block filters
May 4 2019, 17:17
jimpo closed D2867: blockfilter: add block filters.
May 4 2019, 17:17

Apr 25 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints. (authored by jimpo).
serialize: Serialization support for big-endian 32-bit ints.
Apr 25 2019, 19:45
jimpo closed D2873: serialize: Serialization support for big-endian 32-bit ints..
Apr 25 2019, 19:45

Apr 23 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC17ef4aee5c51: Extract CSipHasher to it's own file in crypto/ directory. (authored by jimpo).
Extract CSipHasher to it's own file in crypto/ directory.
Apr 23 2019, 01:16
jimpo closed D2800: Extract CSipHasher to it's own file in crypto/ directory..
Apr 23 2019, 01:16

Apr 16 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC725577a96c74: blockfilter: add GCSFilter class (authored by jimpo).
blockfilter: add GCSFilter class
Apr 16 2019, 23:21
jimpo closed D2803: blockfilter: add GCSFilter class.
Apr 16 2019, 23:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC0925cf776a90: streams: Implement BitStreamReader/Writer classes. (authored by jimpo).
streams: Implement BitStreamReader/Writer classes.
Apr 16 2019, 23:17
jimpo closed D2799: streams: Implement BitStreamReader/Writer classes..
Apr 16 2019, 23:17
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC6c25e0941fc8: streams: Create VectorReader stream interface for vectors. (authored by jimpo).
streams: Create VectorReader stream interface for vectors.
Apr 16 2019, 22:35
jimpo closed D2797: streams: Create VectorReader stream interface for vectors..
Apr 16 2019, 22:35

Sep 27 2018

jimpo committed rSTAGINGbc24189fbecf: [Part 5] Refactor logging code into a global object (authored by jimpo).
[Part 5] Refactor logging code into a global object
Sep 27 2018, 18:46
jimpo committed rSTAGING724b2c2aa0f9: [Part 4] Refactor logging code into a global object (authored by jimpo).
[Part 4] Refactor logging code into a global object
Sep 27 2018, 18:46
jimpo committed rSTAGING06db7fa67c81: [Part 3] Refactor logging code into a global object (authored by jimpo).
[Part 3] Refactor logging code into a global object
Sep 27 2018, 18:45
jimpo committed rSTAGING33da593347c4: [Part 2] Refactor logging code into a global object (authored by jimpo).
[Part 2] Refactor logging code into a global object
Sep 27 2018, 18:44
jimpo committed rSTAGINGce400ab43c46: [Part 1] Refactor logging code into a global object (authored by jimpo).
[Part 1] Refactor logging code into a global object
Sep 27 2018, 18:43

May 1 2018

jimpo committed rABCbc24189fbecf: [Part 5] Refactor logging code into a global object (authored by jimpo).
[Part 5] Refactor logging code into a global object
May 1 2018, 01:35
jimpo closed D1284: [Part 5] Refactor logging code into a global object.
May 1 2018, 01:35
jimpo committed rABC724b2c2aa0f9: [Part 4] Refactor logging code into a global object (authored by jimpo).
[Part 4] Refactor logging code into a global object
May 1 2018, 01:32
jimpo closed D1283: [Part 4] Refactor logging code into a global object.
May 1 2018, 01:31

Apr 30 2018

jimpo updated the summary of D1284: [Part 5] Refactor logging code into a global object.
Apr 30 2018, 18:13
jimpo updated the diff for D1284: [Part 5] Refactor logging code into a global object.
  • logging: Remove use of ARRAYLEN from utilstrencodings.
  • logging: Change boost::mutex to std::mutex.
Apr 30 2018, 18:12
jimpo updated the diff for D1283: [Part 4] Refactor logging code into a global object.

Rebased.

Apr 30 2018, 18:01

Apr 27 2018

jimpo updated the diff for D1283: [Part 4] Refactor logging code into a global object.

Rebased onto master.

Apr 27 2018, 01:51
jimpo committed rABC06db7fa67c81: [Part 3] Refactor logging code into a global object (authored by jimpo).
[Part 3] Refactor logging code into a global object
Apr 27 2018, 01:47
jimpo closed D1282: [Part 3] Refactor logging code into a global object.
Apr 27 2018, 01:47

Apr 20 2018

jimpo updated the diff for D1282: [Part 3] Refactor logging code into a global object.

Rebased onto master.

Apr 20 2018, 23:06
jimpo committed rABC33da593347c4: [Part 2] Refactor logging code into a global object (authored by jimpo).
[Part 2] Refactor logging code into a global object
Apr 20 2018, 23:02
jimpo closed D1281: [Part 2] Refactor logging code into a global object.
Apr 20 2018, 23:02
jimpo added a comment to D1281: [Part 2] Refactor logging code into a global object.

@jasonbcox @schancel I completely agree on not using Hungarian notation for new code, but changing these variable names would increase the diff size. If you want, I would prefer to rename all of the variables in a future diff that just does the renaming.

Apr 20 2018, 22:31
jimpo accepted D1298: Update developer notes and link to it from contributing docs.
Apr 20 2018, 03:00
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Remove unused <memory> include.

Apr 20 2018, 00:03

Apr 19 2018

jimpo added inline comments to D1298: Update developer notes and link to it from contributing docs.
Apr 19 2018, 21:14

Apr 18 2018

jimpo added inline comments to D1281: [Part 2] Refactor logging code into a global object.
Apr 18 2018, 18:53

Apr 17 2018

jimpo updated the diff for D1284: [Part 5] Refactor logging code into a global object.

Rebased.

Apr 17 2018, 07:51
jimpo updated the diff for D1283: [Part 4] Refactor logging code into a global object.

Rebased.

Apr 17 2018, 07:51
jimpo updated the diff for D1282: [Part 3] Refactor logging code into a global object.

Rebased.

Apr 17 2018, 07:50
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Switched back to GetLogger function.

Apr 17 2018, 07:49
jimpo added a comment to D1295: Ensure checks are enforced in core_read.cpp for all push types.

This does not enforce that if push_size is set that the next value is raw data. For example, the test case "PUSHDATA2 PUSHDATA1" would pass, I think.

Apr 17 2018, 05:43
jimpo updated the diff for D1282: [Part 3] Refactor logging code into a global object.

Rebased.

Apr 17 2018, 00:22
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Change g_logger to a *const instead of function with mutex.

Apr 17 2018, 00:16

Apr 16 2018

jimpo added inline comments to D1293: Add basic sanity checking for script pushdata size.
Apr 16 2018, 22:17
jimpo added inline comments to D1288: Add nTimeReceived to CBlockIndex for tracking recevied time of blocks.
Apr 16 2018, 18:38

Apr 14 2018

jimpo updated the diff for D1283: [Part 4] Refactor logging code into a global object.

Rebased.

Apr 14 2018, 19:31
jimpo updated the diff for D1282: [Part 3] Refactor logging code into a global object.

Rebased.

Apr 14 2018, 19:30
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Update member variable comment for fStartedNewLine.

Apr 14 2018, 19:29
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Replaced std::unique_ptr to global logger with a thread-safe GetLogger method as discussed in chat.

Apr 14 2018, 19:24
jimpo added inline comments to D1283: [Part 4] Refactor logging code into a global object.
Apr 14 2018, 19:19

Apr 13 2018

jimpo added a comment to D1281: [Part 2] Refactor logging code into a global object.

The thread safety is tricky.

Apr 13 2018, 15:03

Apr 12 2018

jimpo committed rABCce400ab43c46: [Part 1] Refactor logging code into a global object (authored by jimpo).
[Part 1] Refactor logging code into a global object
Apr 12 2018, 23:32
jimpo closed D1280: [Part 1] Refactor logging code into a global object.
Apr 12 2018, 23:32
jimpo updated the diff for D1280: [Part 1] Refactor logging code into a global object.

Adding logging.cpp to CMakeLists.txt.

Apr 12 2018, 21:45
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Use global LogPrintf in util.h instead of Logger method.

Apr 12 2018, 20:26
jimpo updated the diff for D1280: [Part 1] Refactor logging code into a global object.

Fix copyright notices and extraneous change to util.h.

Apr 12 2018, 20:23
jimpo added inline comments to D1280: [Part 1] Refactor logging code into a global object.
Apr 12 2018, 20:11
jimpo abandoned D1276: Refactor logging code into a global object.

Superceded by https://reviews.bitcoinabc.org/D1280, https://reviews.bitcoinabc.org/D1281, https://reviews.bitcoinabc.org/D1282, https://reviews.bitcoinabc.org/D1283, https://reviews.bitcoinabc.org/D1284

Apr 12 2018, 19:53
jimpo created D1284: [Part 5] Refactor logging code into a global object.
Apr 12 2018, 19:51
Herald added a reviewer for D1283: [Part 4] Refactor logging code into a global object: Restricted Project.
Apr 12 2018, 19:47
jimpo updated the summary of D1280: [Part 1] Refactor logging code into a global object.
Apr 12 2018, 19:43
jimpo updated the summary of D1281: [Part 2] Refactor logging code into a global object.
Apr 12 2018, 19:42
Herald added a reviewer for D1282: [Part 3] Refactor logging code into a global object: Restricted Project.
Apr 12 2018, 19:42
jimpo updated the diff for D1281: [Part 2] Refactor logging code into a global object.

Added braces around an if statement.

Apr 12 2018, 19:35
Herald added a reviewer for D1281: [Part 2] Refactor logging code into a global object: Restricted Project.
Apr 12 2018, 19:30
Herald added a reviewer for D1280: [Part 1] Refactor logging code into a global object: Restricted Project.
Apr 12 2018, 19:03
jimpo added a comment to D1276: Refactor logging code into a global object.

Yes, this diff does a lot at once, however each commit is fairly well scoped. It is much easier to review commit by commit, which I now realize is not that easy with Phabricator. The commits actually do take the approach you are describing of moving the same implementation behind a new interface, and only afterwards changing behavior. Is the recommended approach to break each commit into a separate diff?

Apr 12 2018, 18:43

Apr 11 2018

Herald added a reviewer for D1277: WIP: Prototype structured key-value logger.: Restricted Project.
Apr 11 2018, 17:18
jimpo updated the summary of D1276: Refactor logging code into a global object.
Apr 11 2018, 07:30
Herald added a reviewer for D1276: Refactor logging code into a global object: Restricted Project.
Apr 11 2018, 07:27

Apr 10 2018

jimpo added a comment to T317: Add address indexes.

I have a pull request open on Bitcoin Core that creates a precedent for parallel indexing: https://github.com/bitcoin/bitcoin/pull/11857. I would really like to see any new indexes created with a similar pattern, driven off of ValidationInterface instead of inline in the validation code.

Apr 10 2018, 18:43
jimpo added a comment to T196: Storage block arrival time.

CBlockIndex entries already have an nSequenceId, which may serve the same purpose. It not persisted, however, and set to 0 for all blocks on disk and incremented for each block received while the process is running.

Apr 10 2018, 18:29
jimpo added a comment to T316: Split TxID and TxHash and use them properly across the codebase.

Can you explain this further? Do you just renaming variables and methods with txid or txhash in the name?

Apr 10 2018, 18:18 · Bootcamp