HomePhabricator

blockfilter: add block filters

Description

blockfilter: add block filters

Summary:
Part of BIP158, this is made from last backports from PR 12254:
97b64d67d blockfilter: Unit test against BIP 158 test vectors.
a4afb9cad blockfilter: Additional helper methods to compute hash and header.
cd09c7925 blockfilter: Serialization methods on BlockFilter.
c1855f605 blockfilter: Construction of basic block filters.

plus a fix from PR 14073:
f05599557 blockfilter: Omit empty scripts from filter contents.

Two test cases containing segwit coinbase transactions were removed from
blockfilter_tests.json due to their failing to parse, and inapplicability.

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Maniphest Tasks: T589

Differential Revision: https://reviews.bitcoinabc.org/D2867

Details

Provenance
jimpoAuthored on May 4 2019, 17:09
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on May 4 2019, 17:17
markblundebergPushed on May 4 2019, 17:17
Reviewer
Restricted Project
Differential Revision
D2867: blockfilter: add block filters
Parents
rABCf4025afda6a9: Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf1cf81504278: blockfilter: add block filters (authored by jimpo).May 4 2019, 17:17