Page MenuHomePhabricator

blockfilter: add GCSFilter class
ClosedPublic

Authored by markblundeberg on Apr 14 2019, 05:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rABC725577a96c74: blockfilter: add GCSFilter class
Summary

This incorporates six commits from jimpo's PR 12254 for BIP158:

254c85b68 bench: Benchmark GCS filter creation and matching.
f33b717a8 blockfilter: Optimization on compilers with int128 support.
53e7874e0 blockfilter: Simple test for GCSFilter construction and Match.
558c536e3 blockfilter: Implement GCSFilter Match methods.
cf70b5500 blockfilter: Implement GCSFilter constructors.
c454f0ac6 blockfilter: Declare GCSFilter class for BIP 158 impl.

Depends on D2799

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Apr 14 2019, 05:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2019, 05:30
deadalnix requested changes to this revision.Apr 14 2019, 19:33
deadalnix added inline comments.
src/bench/gcs_filter.cpp
13 ↗(On Diff #8050)

fix

30 ↗(On Diff #8050)

fix

src/blockfilter.h
9 ↗(On Diff #8050)

cstdint

13 ↗(On Diff #8050)

Include application headers before systems headers

This revision now requires changes to proceed.Apr 14 2019, 19:33
markblundeberg marked 4 inline comments as done.

char eradication and header normalization

deadalnix requested changes to this revision.Apr 15 2019, 11:22
deadalnix added inline comments.
src/Makefile.test.include
41 ↗(On Diff #8053)

This must be added to the cmake build.

This revision now requires changes to proceed.Apr 15 2019, 11:22
markblundeberg marked an inline comment as done.

forgot cmakelists for test

deadalnix accepted this revision.Apr 16 2019, 22:52
This revision is now accepted and ready to land.Apr 16 2019, 22:52
This revision was automatically updated to reflect the committed changes.